From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.haj.ipfire.org (localhost [127.0.0.1]) by mail02.haj.ipfire.org (Postfix) with ESMTP id 4b3C8p36lBz336G for ; Thu, 22 May 2025 15:37:30 +0000 (UTC) Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) client-signature RSA-PSS (4096 bits)) (Client CN "mail01.haj.ipfire.org", Issuer "R10" (verified OK)) by mail02.haj.ipfire.org (Postfix) with ESMTPS id 4b3C8k6yHsz32f1 for ; Thu, 22 May 2025 15:37:26 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail01.ipfire.org (Postfix) with ESMTPSA id 4b3C8k3Tdsz6P; Thu, 22 May 2025 15:37:26 +0000 (UTC) DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003ed25519; t=1747928246; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ivdnb3M9SPR3RnNnzhjfCYl8u1tb5r9x2eAIBTJEkKs=; b=ROwSBPPtKXd+ChDz4tjiax5OR9VTydWp49D8Q8Ojzx3zaRvtGK/bPybi9HPgRtSl+hrNg5 bHrWFOumwjPGNPBw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003rsa; t=1747928246; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ivdnb3M9SPR3RnNnzhjfCYl8u1tb5r9x2eAIBTJEkKs=; b=r0+DityC/0UqPMYsvzANp68DycUrVnzmKy9cmB7L7kB1XiqbCsKK88aBs26UIWYvw8+vjT DBTmrubCMRnpRKdDoZZffyZKZdaGxXvu+Vm93ZzPtn3nJ1iKY1ZhkdC79+HMmclifqk+dL uYan2lfRUFz17B0BVaZzYPdrfaoeqCSn7sZVEyYhUU24qB+kZhNR9/8ngsnHiwmOLBWy/A nuePHf0Rcq4VfDs4psIuRe1k1QzCd8sMkg/yNr4xrfuEO9wjIxesCI0Uh1suLMObhtOBsk G6SFmHG/Ay/p8x88ViqdfXBt1TwEovhayzJNjFS4iwB5ePNn5epcBWKca8hA9w== Content-Type: text/plain; charset=us-ascii Precedence: list List-Id: List-Subscribe: , List-Unsubscribe: , List-Post: List-Help: Sender: Mail-Followup-To: Mime-Version: 1.0 Subject: Re: [PATCH] screen: Update to version 5.0.1 From: Michael Tremer In-Reply-To: <20250515162525.3301332-1-adolf.belka@ipfire.org> Date: Thu, 22 May 2025 16:37:26 +0100 Cc: development@lists.ipfire.org Content-Transfer-Encoding: quoted-printable Message-Id: <98828B86-5323-4EFA-9278-6BB578AB77E2@ipfire.org> References: <20250515162525.3301332-1-adolf.belka@ipfire.org> To: Adolf Belka Hello Adolf, Thank you for this patch. I had merged this into next, but I will revert = this again. screen seems to ship binary objects in the source tarball: root@arm64-01:/build/ipfire-2.x# tar tvfa cache/screen-5.0.1.tar.gz | = grep \.o$ -rw-rw-r-- alex/alex 16712 2025-05-12 11:59 screen-5.0.1/sched.o -rw-rw-r-- alex/alex 43808 2025-05-12 11:59 screen-5.0.1/backtick.o -rw-rw-r-- alex/alex 9080 2025-05-12 11:59 = screen-5.0.1/winmsgcond.o -rw-rw-r-- alex/alex 81728 2025-05-12 11:59 screen-5.0.1/canvas.o -rw-rw-r-- alex/alex 50680 2025-05-12 11:59 screen-5.0.1/search.o -rw-rw-r-- alex/alex 32752 2025-05-12 11:59 screen-5.0.1/winmsgbuf.o -rw-rw-r-- alex/alex 11888 2025-05-12 11:59 screen-5.0.1/term.o -rw-rw-r-- alex/alex 2800 2025-05-12 11:59 screen-5.0.1/telnet.o -rw-rw-r-- alex/alex 54224 2025-05-12 11:59 screen-5.0.1/layout.o -rw-rw-r-- alex/alex 107776 2025-05-12 11:59 screen-5.0.1/mark.o -rw-rw-r-- alex/alex 58640 2025-05-12 11:59 = screen-5.0.1/list_generic.o -rw-rw-r-- alex/alex 55912 2025-05-12 11:59 screen-5.0.1/input.o -rw-rw-r-- alex/alex 97520 2025-05-12 11:59 screen-5.0.1/winmsg.o -rw-rw-r-- alex/alex 108256 2025-05-12 11:59 screen-5.0.1/layer.o -rw-rw-r-- alex/alex 50344 2025-05-12 11:59 screen-5.0.1/misc.o -rw-rw-r-- alex/alex 166432 2025-05-12 11:59 screen-5.0.1/window.o -rw-rw-r-- alex/alex 72440 2025-05-12 11:59 screen-5.0.1/help.o -rw-rw-r-- alex/alex 154704 2025-05-12 11:59 screen-5.0.1/termcap.o -rw-rw-r-- alex/alex 300672 2025-05-12 11:59 screen-5.0.1/display.o -rw-rw-r-- alex/alex 73432 2025-05-12 11:59 = screen-5.0.1/list_window.o -rw-rw-r-- alex/alex 85392 2025-05-12 11:59 screen-5.0.1/resize.o -rw-rw-r-- alex/alex 650104 2025-05-12 11:59 screen-5.0.1/process.o -rw-rw-r-- alex/alex 218400 2025-05-12 11:59 screen-5.0.1/ansi.o -rw-rw-r-- alex/alex 6704 2025-05-12 11:59 screen-5.0.1/kmapdef.o -rw-rw-r-- alex/alex 27016 2025-05-12 11:59 screen-5.0.1/logfile.o -rw-rw-r-- alex/alex 6760 2025-05-12 11:59 screen-5.0.1/pty.o -rw-rw-r-- alex/alex 42704 2025-05-12 11:59 = screen-5.0.1/list_display.o -rw-rw-r-- alex/alex 14160 2025-05-12 11:59 screen-5.0.1/comm.o -rw-rw-r-- alex/alex 231600 2025-05-12 12:08 = screen-5.0.1/doc/screen.texinfo -rw-rw-r-- alex/alex 42936 2025-05-12 11:59 = screen-5.0.1/list_license.o -rw-rw-r-- alex/alex 146368 2025-05-12 11:59 screen-5.0.1/socket.o -rw-rw-r-- alex/alex 4176 2025-05-12 11:59 screen-5.0.1/utmp.o -rw-rw-r-- alex/alex 78792 2025-05-12 11:59 screen-5.0.1/acls.o -rw-rw-r-- alex/alex 53560 2025-05-12 11:59 screen-5.0.1/attacher.o -rw-rw-r-- alex/alex 237472 2025-05-12 11:59 screen-5.0.1/screen.o -rw-rw-r-- alex/alex 101016 2025-05-12 11:59 screen-5.0.1/fileio.o -rw-rw-r-- alex/alex 98056 2025-05-12 11:59 screen-5.0.1/encoding.o -rw-rw-r-- alex/alex 29592 2025-05-12 11:59 screen-5.0.1/viewport.o -rw-rw-r-- alex/alex 77104 2025-05-12 11:59 screen-5.0.1/tty.o They seem to be x86_64, and so the build fails on ARM. This is however = either a mistake or I would consider this a way to ship any backdoored = software. I have no time to investigate so I am going to assume the = latter for now and will be *very* careful. -Michael > On 15 May 2025, at 17:25, Adolf Belka wrote: >=20 > - Update from version 5.0.0 to 5.0.1 > - Update of rootfile > - 5 CVE fixes included in this version > - Changelog > 5.0.1 > Security fix > CVE-2025-46805: do NOT send signals with root privileges > CVE-2025-46804: avoid file existence test information leaks > CVE-2025-46803: apply safe PTY default mode of 0620 > CVE-2025-46802: prevent temporary 0666 mode on PTYs in attacher > CVE-2025-23395: reintroduce lf_secreopen() for logfile > buffer overflow due bad strncpy() > uninitialized variables warnings > typos > combining char handling that could lead to a segfault >=20 > Signed-off-by: Adolf Belka > --- > config/rootfiles/common/screen | 3 +-- > lfs/screen | 6 +++--- > 2 files changed, 4 insertions(+), 5 deletions(-) >=20 > diff --git a/config/rootfiles/common/screen = b/config/rootfiles/common/screen > index 3442bff2b..e8b72aaa2 100644 > --- a/config/rootfiles/common/screen > +++ b/config/rootfiles/common/screen > @@ -1,7 +1,6 @@ > etc/screenrc > usr/bin/screen > -usr/bin/screen-5.0.0 > -#usr/share/info/screen.info > +usr/bin/screen-5.0.1 > #usr/share/man/man1/screen.1 > #usr/share/screen > #usr/share/screen/utf8encodings > diff --git a/lfs/screen b/lfs/screen > index 6388002cf..d1c0380fb 100644 > --- a/lfs/screen > +++ b/lfs/screen > @@ -1,7 +1,7 @@ > = ##########################################################################= ##### > # = # > # IPFire.org - A linux based firewall = # > -# Copyright (C) 2007-2024 IPFire Team = # > +# Copyright (C) 2007-2025 IPFire Team = # > # = # > # This program is free software: you can redistribute it and/or modify = # > # it under the terms of the GNU General Public License as published by = # > @@ -24,7 +24,7 @@ >=20 > include Config >=20 > -VER =3D 5.0.0 > +VER =3D 5.0.1 >=20 > THISAPP =3D screen-$(VER) > DL_FILE =3D $(THISAPP).tar.gz > @@ -40,7 +40,7 @@ objects =3D $(DL_FILE) >=20 > $(DL_FILE) =3D $(DL_FROM)/$(DL_FILE) >=20 > -$(DL_FILE)_BLAKE2 =3D = 5ff218afc1692ae201776f759ff2217a51dcf02202e4ba5d12de50a768df83e0e2a7a3511a= 5f85a3b21362892f31a4fd90d6444918915165ae12a8c0c2b3af39 > +$(DL_FILE)_BLAKE2 =3D = f33f985bb9855a5335b72f93b3e8cf8fccddc7c18d3db3fd7493da2825b17002d798e6cf95= d35fc39194eb6933018be96efa0b4f6aa4894657ab258f86002220 >=20 > install : $(TARGET) >=20 > --=20 > 2.49.0 >=20 >=20