From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] backup.cgi: Cosmetic fix - mark backup files bold for better readability
Date: Fri, 22 May 2020 15:45:20 +0100 [thread overview]
Message-ID: <9A3C8AB8-8803-46AC-8748-D32C81FE58C9@ipfire.org> (raw)
In-Reply-To: <020d55f4-ea2d-4bf0-1194-7c74ffd04615@ipfire.org>
[-- Attachment #1: Type: text/plain, Size: 5440 bytes --]
Hi,
Yes, that looks much better.
Acked-by: Michael Tremer <michael.tremer(a)ipfire.org>
-Michael
> On 22 May 2020, at 15:17, Matthias Fischer <matthias.fischer(a)ipfire.org> wrote:
>
> Hi,
>
> no problem => please see attached screenshots.
>
> Only the filename is marked bold - for better identification and/or
> readability (e.g.).
>
> Best,
> Matthias
>
> On 22.05.2020 14:39, Michael Tremer wrote:
>> Hey,
>>
>> Can you post a screenshot about what has changed and why this was a problem for you?
>>
>> Best,
>> -Michael
>>
>>> On 22 May 2020, at 13:13, Matthias Fischer <matthias.fischer(a)ipfire.org> wrote:
>>>
>>> Signed-off-by: Matthias Fischer <matthias.fischer(a)ipfire.org>
>>> ---
>>> html/cgi-bin/backup.cgi | 12 ++++++------
>>> 1 file changed, 6 insertions(+), 6 deletions(-)
>>>
>>> diff --git a/html/cgi-bin/backup.cgi b/html/cgi-bin/backup.cgi
>>> index cac4146ab..3ced1371d 100644
>>> --- a/html/cgi-bin/backup.cgi
>>> +++ b/html/cgi-bin/backup.cgi
>>> @@ -202,7 +202,7 @@ my $Datei = "/var/ipfire/backup/".$_;
>>> my @Info = stat($Datei);
>>> my $Size = $Info[7] / 1024 / 1024;
>>> $Size = sprintf("%0.2f", $Size);
>>> -print "<tr><td align='center'>$Lang::tr{'backup from'} $_ $Lang::tr{'size'} $Size MB</td><td width='5'><form method='post' action='$ENV{'SCRIPT_NAME'}'><input type='hidden' name='ACTION' value='download' /><input type='hidden' name='FILE' value='$_' /><input type='image' alt='$Lang::tr{'download'}' title='$Lang::tr{'download'}' src='/images/package-x-generic.png' /></form></td>";
>>> +print "<tr><td align='center'>$Lang::tr{'backup from'} <b>$_</b> $Lang::tr{'size'} $Size MB</td><td width='5'><form method='post' action='$ENV{'SCRIPT_NAME'}'><input type='hidden' name='ACTION' value='download' /><input type='hidden' name='FILE' value='$_' /><input type='image' alt='$Lang::tr{'download'}' title='$Lang::tr{'download'}' src='/images/package-x-generic.png' /></form></td>";
>>> print "<td width='5'><form method='post' action='$ENV{'SCRIPT_NAME'}'><input type='hidden' name='ACTION' value='delete' /><input type='hidden' name='FILE' value='$_' /><input type='image' alt='$Lang::tr{'delete'}' title='$Lang::tr{'delete'}' src='/images/user-trash.png' /></form></td></tr>";
>>> }
>>> foreach (@backupisos){
>>> @@ -212,7 +212,7 @@ my $Datei = "/var/tmp/backupiso/".$_;
>>> my @Info = stat($Datei);
>>> my $Size = $Info[7] / 1024 / 1024;
>>> $Size = sprintf("%0.2f", $Size);
>>> -print "<tr><td align='center'>$Lang::tr{'backup from'} $_ $Lang::tr{'size'} $Size MB</td><td width='5'><form method='post' action='$ENV{'SCRIPT_NAME'}'><input type='hidden' name='ACTION' value='downloadiso' /><input type='hidden' name='FILE' value='$_' /><input type='image' alt='$Lang::tr{'download'}' title='$Lang::tr{'download'}' src='/images/package-x-generic.png' /></form></td>";
>>> +print "<tr><td align='center'>$Lang::tr{'backup from'} <b>$_</b> $Lang::tr{'size'} $Size MB</td><td width='5'><form method='post' action='$ENV{'SCRIPT_NAME'}'><input type='hidden' name='ACTION' value='downloadiso' /><input type='hidden' name='FILE' value='$_' /><input type='image' alt='$Lang::tr{'download'}' title='$Lang::tr{'download'}' src='/images/package-x-generic.png' /></form></td>";
>>> print "<td width='5'><form method='post' action='$ENV{'SCRIPT_NAME'}'><input type='hidden' name='ACTION' value='delete' /><input type='hidden' name='FILE' value='$_' /><input type='image' alt='$Lang::tr{'delete'}' title='$Lang::tr{'delete'}' src='/images/user-trash.png' /></form></td></tr>";
>>> }
>>> print <<END
>>> @@ -246,10 +246,10 @@ my $Size = $Info[7] / 1024;
>>> if ( -e $Datei ){
>>> if ($Size < 1) {
>>> $Size = sprintf("%.2f", $Size);
>>> - print "<tr><td align='center'>$Lang::tr{'backup from'} $_ $Lang::tr{'size'} $Size KB $Lang::tr{'date'} ".localtime($Info[9])."</td>";
>>> + print "<tr><td align='center'>$Lang::tr{'backup from'} <b>$_</b> $Lang::tr{'size'} $Size KB $Lang::tr{'date'} ".localtime($Info[9])."</td>";
>>> } else {
>>> $Size = sprintf("%2d", $Size);
>>> - print "<tr><td align='center'>$Lang::tr{'backup from'} $_ $Lang::tr{'size'} $Size KB $Lang::tr{'date'} ".localtime($Info[9])."</td>";
>>> + print "<tr><td align='center'>$Lang::tr{'backup from'} <b>$_</b> $Lang::tr{'size'} $Size KB $Lang::tr{'date'} ".localtime($Info[9])."</td>";
>>>
>>> }
>>>
>>> @@ -272,7 +272,7 @@ END
>>> ;
>>> }
>>> else{
>>> - print "<tr><td align='center'>$Lang::tr{'backup from'} $_ </td><td width='5' align='right'></td><td width='5' align='right'></td>";
>>> + print "<tr><td align='center'>$Lang::tr{'backup from'} <b>$_</b> </td><td width='5' align='right'></td><td width='5' align='right'></td>";
>>> }
>>> print <<END
>>> <td align='right' width='5'>
>>> @@ -291,7 +291,7 @@ my $Datei = "/var/ipfire/backup/addons/backup/".$_.".ipf";
>>> my @Info = stat($Datei);
>>> my $Size = $Info[7] / 1024;
>>> $Size = sprintf("%2d", $Size);
>>> -print "<tr><td align='center'>$Lang::tr{'backup from'} $_ $Lang::tr{'size'} $Size KB $Lang::tr{'date'} ".localtime($Info[9])."</td>";
>>> +print "<tr><td align='center'>$Lang::tr{'backup from'} <b>$_</b> $Lang::tr{'size'} $Size KB $Lang::tr{'date'} ".localtime($Info[9])."</td>";
>>> print <<END
>>> <td align='right' width='5'>
>>> <form method='post' action='$ENV{'SCRIPT_NAME'}'>
>>> --
>>> 2.18.0
>>>
>>
>
> <after.png><before.png>
next parent reply other threads:[~2020-05-22 14:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <020d55f4-ea2d-4bf0-1194-7c74ffd04615@ipfire.org>
2020-05-22 14:45 ` Michael Tremer [this message]
2020-05-22 12:13 Matthias Fischer
2020-05-22 12:39 ` Michael Tremer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9A3C8AB8-8803-46AC-8748-D32C81FE58C9@ipfire.org \
--to=michael.tremer@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox