From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] Core Update 171: Ship libsodium
Date: Tue, 27 Sep 2022 09:16:38 +0100
Message-ID: <9B307A13-3D4F-4B73-8D94-F463B0BA7B2C@ipfire.org>
In-Reply-To: <9c35618c-d07b-a8c3-7e98-44e04787b152@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1900887686179744764=="
List-Id: <development.lists.ipfire.org>

--===============1900887686179744764==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello Adolf,

Sorry, I overlooked that question.

I am currently fairly indifferent about this, but since the library is kind o=
f small, it might be a better idea to have it as part of the core system.

-Michael

> On 27 Sep 2022, at 09:09, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>=20
> Hi Michael,
>=20
> On 18/09/2022 12:44, Adolf Belka wrote:
>> Hi Michael,
>>=20
>> On 18/09/2022 11:08, Michael Tremer wrote:
>>> Why?
>> Because dnsdist has the default for the configure option of --with-libsodi=
um set to auto so in the p[ast dnsdist was built without linking to libsodium=
. With the introduction of libsodium into the build dnsdist automatically fou=
nd it and linked to it.
>>=20
>> So when libsodium was not shipped then dnsdist fails because it can't find=
 the linked libsodium.so.23 file.
>>=20
>> If you don't want to ship libsodium, then the other alternative is that I =
can raise a patch to add --without-libsodium to the dnsdist configure. That w=
ill make it build and run with libsodium being in the build but not in the sh=
ipped core packages.
>>=20
>> Which way should I do this?
>>=20
> Is there a decision made about which option to use?
> - Ship libsodium in core IPFire
> - Build dnsdist without libsodium
>=20
> Regards,
> Adolf
>> Regards,
>>=20
>> Adolf.
>>>=20
>>>> On 17 Sep 2022, at 23:09, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>>>>=20
>>>> Reviewed-by: Adolf Belka <adolf.belka(a)ipfire.org>
>>>>=20
>>>> On 17/09/2022 18:53, Peter M=C3=BCller wrote:
>>>>> Fixes: #12929
>>>>> Signed-off-by: Peter M=C3=BCller <peter.mueller(a)ipfire.org>
>>>>> ---
>>>>> config/rootfiles/core/171/filelists/libsodium | 1 +
>>>>> 1 file changed, 1 insertion(+)
>>>>> create mode 120000 config/rootfiles/core/171/filelists/libsodium
>>>>>=20
>>>>> diff --git a/config/rootfiles/core/171/filelists/libsodium b/config/roo=
tfiles/core/171/filelists/libsodium
>>>>> new file mode 120000
>>>>> index 000000000..ebd862fbc
>>>>> --- /dev/null
>>>>> +++ b/config/rootfiles/core/171/filelists/libsodium
>>>>> @@ -0,0 +1 @@
>>>>> +../../../common/libsodium
>>>>> \ No newline at end of file
>>>>=20
>>>> --=20
>>>> Sent from my laptop
>>>=20
>=20
> --=20
> Sent from my laptop


--===============1900887686179744764==--