From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] Core Update 165: Restart Squid during the update
Date: Wed, 23 Mar 2022 09:35:30 +0000
Message-ID: <9D34E0D8-95F6-4970-9B1B-22317FFB4A71@ipfire.org>
In-Reply-To: <84091192-0fdf-d0dc-50d4-adc61c289808@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2756486077002068123=="
List-Id: <development.lists.ipfire.org>

--===============2756486077002068123==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello,

> On 23 Mar 2022, at 09:34, Peter M=C3=BCller <peter.mueller(a)ipfire.org> wr=
ote:
>=20
> Hello Adolf,
> hello Michael,
>=20
> thanks for your replies.
>=20
> Indeed, Core Update 165 does not contain a new version of Squid, and indeed=
, there
> is bug #12623 for an issue where the proxy is not being started properly du=
ring boot.
> I was unfortunately never able to reproduce this, or understand from the sc=
anty logs
> supplied what went wrong here. :-/

Arne confirmed to me yesterday that he has seen the proxy not coming up prope=
rly on a test system. Maybe he can help finding this?

> So, whatever went wrong on my testing machine with Squid and Core Update 16=
5, let's
> drop this patch - people are urged to reboot their IPFire installations as =
soon as
> possible anyways.
>=20
> Thanks, and best regards,
> Peter M=C3=BCller
>=20
>=20
>> Hmm, okay.
>>=20
>> So when a service is being updated, it should be stopped before the update=
 is applied and restarted after the update is done.
>>=20
>> We usually do that - unless it is forgotten, which happens occasionally. T=
hat should however not break anything.
>>=20
>> -Michael
>>=20
>>> On 21 Mar 2022, at 09:01, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>>>=20
>>> Hi Peter,
>>>=20
>>> On 20/03/2022 19:32, Peter M=C3=BCller wrote:
>>>> Hello Michael,
>>>>=20
>>>> thanks for your reply.
>>>>=20
>>>> This is necessary because (a) we ship a new version of Squid with Core U=
pdate 165
>>>> and (b) not restarting Squid afterwards caused the web proxy to stall on=
 my testing
>>>> machine.
>>> Following is for info.
>>>=20
>>> On my vm testbed I have all items running on the Services table and after=
 the CU to 165 they were all still running.
>>> I have never had a problem with the Web Proxy stopping running after any =
Core Update.
>>>=20
>>> However there have been threads where people have reported occasionally t=
hat there web proxy has stopped after a core update but usually a reboot reso=
lved that.
>>>=20
>>> Some people have reported, and I think there is still a bug open on this,=
 where the web proxy periodically stops working in normal operation and has t=
o be restarted or IPFire has to be rebooted to restart it. Unfortunately thos=
e bug/thread originators have not usually provided logs or the logs provided =
have not shown any issue.
>>>=20
>>> Regards,
>>> Adolf.
>>>> Thanks, and best regards,
>>>> Peter M=C3=BCller
>>>>=20
>>>>=20
>>>>> Why is this necessary?
>>>>>=20
>>>>>> On 20 Mar 2022, at 10:20, Peter M=C3=BCller <peter.mueller(a)ipfire.or=
g> wrote:
>>>>>>=20
>>>>>> Fixes: #12810
>>>>>>=20
>>>>>> Signed-off-by: Peter M=C3=BCller <peter.mueller(a)ipfire.org>
>>>>>> ---
>>>>>> config/rootfiles/core/165/update.sh | 1 +
>>>>>> 1 file changed, 1 insertion(+)
>>>>>>=20
>>>>>> diff --git a/config/rootfiles/core/165/update.sh b/config/rootfiles/co=
re/165/update.sh
>>>>>> index ffb552c80..2c2e6a10c 100644
>>>>>> --- a/config/rootfiles/core/165/update.sh
>>>>>> +++ b/config/rootfiles/core/165/update.sh
>>>>>> @@ -128,6 +128,7 @@ ldconfig
>>>>>> # Start services
>>>>>> telinit u
>>>>>> /etc/rc.d/init.d/firewall restart
>>>>>> +/etc/rc.d/init.d/squid restart
>>>>>>=20
>>>>>> # Fix ownership of classification file.
>>>>>> chown nobody:nobody /usr/share/suricata/classification.config
>>>>>> --=20
>>>>>> 2.34.1
>>>=20
>>> --=20
>>> Sent from my laptop
>>=20


--===============2756486077002068123==--