From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] vpnmain.cgi: Fix writing ESP settings for PFS ciphers
Date: Mon, 17 Jun 2019 16:31:52 +0100 [thread overview]
Message-ID: <9F68F24B-956A-4BCA-B487-88273B09109E@ipfire.org> (raw)
In-Reply-To: <a777231c-e588-3895-b508-7f13795949da@ipfire.org>
[-- Attachment #1: Type: text/plain, Size: 1033 bytes --]
Oops. Yes.
Weirdly, someone confirmed that this patch works for them…
> On 17 Jun 2019, at 15:08, Peter Müller <peter.mueller(a)ipfire.org> wrote:
>
> The changes introduced due to #12091 caused IPsec ESP
> to be invalid if PFS ciphers were selected. Code has
> to read "!$pfs" instead of just "$pfs", as it should trigger
> for ciphers _without_ Perfect Forward Secrecy.
>
> Fixes #12099
>
> Signed-off-by: Peter Müller <peter.mueller(a)ipfire.org>
> Cc: Michael Tremer <michael.tremer(a)ipfire.org>
> ---
> html/cgi-bin/vpnmain.cgi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/html/cgi-bin/vpnmain.cgi b/html/cgi-bin/vpnmain.cgi
> index fbc274919..750b69b1d 100644
> --- a/html/cgi-bin/vpnmain.cgi
> +++ b/html/cgi-bin/vpnmain.cgi
> @@ -3338,7 +3338,7 @@ sub make_algos($$$$$) {
> push(@algo, $int);
> }
>
> - if ($pfs || $grp eq "none") {
> + if (!$pfs || $grp eq "none") {
> # noop
> } elsif ($grp =~ m/^e(.*)$/) {
> push(@algo, "ecp$1");
> --
> 2.16.4
next prev parent reply other threads:[~2019-06-17 15:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-17 14:08 Peter Müller
2019-06-17 15:31 ` Michael Tremer [this message]
2019-06-19 20:38 ` Peter Müller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9F68F24B-956A-4BCA-B487-88273B09109E@ipfire.org \
--to=michael.tremer@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox