From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adolf Belka To: development@lists.ipfire.org Subject: Re: [V2] Backup.cgi: Rework and altering of functionalities and GUI for better usability Date: Wed, 26 May 2021 17:53:02 +0200 Message-ID: <9a46819c-dcc7-7660-92dc-e28fffc2aac1@ipfire.org> In-Reply-To: <84fe99d7-da07-b4f2-0705-4dd5d5934645@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3445148632120440846==" List-Id: --===============3445148632120440846== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Matthias, On 26/05/2021 17:32, Matthias Fischer wrote: > Hi Adolf, >=20 > On 26.05.2021 13:01, Adolf Belka wrote: >> Hi Matthias, >> >> On 22/05/2021 16:53, Matthias Fischer wrote: >>> Still based on https://bugzilla.ipfire.org/show_bug.cgi?id=3D12588 >>> >>> Hi, >>> >>> in the meantime I worked on this - a bit - again. Currently, this CGI is >>> running here under Core 156 with no seen problems. >>> >>> I've made several changes and adjustments. >>> >>> First: >>> - I kept the icons - buttons didn't look as I hoped they would. ;-) >>> >>> - I kept the old icon order "Download - Delete - Save". >>> >>> Changelog: >>> - Cleaned up the code a bit, some if-queries were unnessecary (if >>> ($cgiparams{'ACTION'} eq...). >>> >>> - Therefore, some lang strings became obsolete ('downloadaddon' and >>> 'downloadiso'. >>> >>> - Separated the ISO files from the IPF files for better overview. >>> >>> - Added query for deleting a backup file (onclick=3D\"return confirm...). >>> >>> - Added 'onclick' feature =3D> deleting a file must be acknowledged. >>> >>> Biggest change: >>> - Added tables - as MT mentioned. >>> >>> Details can be seen in the attached screenshots. >>> >>> Thoughts? Opinions? I'd like to get some feedback before pushing this... = ;-) >> >> It looks okay to me. Alternating shades of grey for the rows as mentioned = by Michael would also be fine. >=20 > Nice. Thanks. But... >=20 > At the moment I have no idea how to change this CGI to show these > alternating rows. I never did this. For a start I looked into some other > CGIs to get a grip (e.g.: dns, firewall, fwhosts, hosts, services, > wakeonlan, wio and log.dat). > But alternate rows seem to be a bit more complicated to me than the > tables. Hm. > [I'm not an experienced programmer with CGI (call me > "scriptkiddie" ;-) ).] Same here. Join the club. I just have a bit of a passing knowledge of=20 the Fixed Leases table in dhcp.cgi I have been doing some fixes in that table, very slowly, but found out=20 about the alternating shades of grey while I was investigating. If it would be useful I could have a look at that when you provide the diff. >=20 > If everything fails, I'll have to ask for hints how to do this. I'll see > how far I can get. >=20 >> Any chance of a diff so I can try it out on a testbed system? >=20 > No problem. Work in progress... >=20 >> By the way, FYI there is another backup umbrella bug https://bugzilla.ipfi= re.org/show_bug.cgi?id=3D11320 >=20 > I'm aware of this. Not much time these days... ;-) Yes, I can imagine. I am luckier as I am retired, although I have found=20 that I still don't have time to do all the things I would like to do but=20 enjoying helping with IPFire. All the best, Adolf. >=20 > Best, > Matthias >=20 --=20 Sent from my laptop --===============3445148632120440846==--