From mboxrd@z Thu Jan  1 00:00:00 1970
From: Adolf Belka <adolf.belka@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH 3/3] perl-Net-SMTP-SSL: Update to 1.04
Date: Mon, 22 Mar 2021 08:44:24 +0100
Message-ID: <9ad0a1f3-2b2d-8fcd-7141-8b22f2f7d710@ipfire.org>
In-Reply-To: <20210322073324.1943-1-adolf.belka@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0387145403160075926=="
List-Id: <development.lists.ipfire.org>

--===============0387145403160075926==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi All,

When updating this dependency of git I saw that it was now deprecated. I=20
had a look at the replacement library and while I could create it as a=20
new addon, it was not clear to me if just defining it as a dependency of=20
git would make git correctly use it.

I am also not sure why anyone would want to run git on a firewall. This=20
addon is not listed in the wiki.

I am therefore not sure if this patch set should be merged or if it=20
should be updated with the new library (and how) or if git should still=20
be left in IPFire as an addon and hence this library.

I am open to whatever decision you think is appropriate for this patch set.

Regards,
Adolf.

On 22/03/2021 08:33, Adolf Belka wrote:
> - Update from 1.02 to 1.04
> - Update of rootfile not required
> - This is a dependency of git addon package
> - Changelog
>     1.04    2016-10-09
>      - mark this library deprecated, suggest newer Net::SMTP instead
>     1.03    2015-06-20
>      - $net_smtp_ssl->isa('Net::SMTP') is now true
>=20
> Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
> ---
>   lfs/perl-Net-SMTP-SSL | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>=20
> diff --git a/lfs/perl-Net-SMTP-SSL b/lfs/perl-Net-SMTP-SSL
> index 90e8a2260..2bb00a808 100644
> --- a/lfs/perl-Net-SMTP-SSL
> +++ b/lfs/perl-Net-SMTP-SSL
> @@ -24,7 +24,7 @@
>  =20
>   include Config
>  =20
> -VER        =3D 1.02
> +VER        =3D 1.04
>  =20
>   THISAPP    =3D Net-SMTP-SSL-$(VER)
>   DL_FILE    =3D ${THISAPP}.tar.gz
> @@ -33,7 +33,7 @@ DIR_APP    =3D $(DIR_SRC)/$(THISAPP)
>   TARGET     =3D $(DIR_INFO)/$(THISAPP)
>   PROG       =3D perl-Net-SMTP-SSL
>   DEPS       =3D
> -PAK_VER    =3D 2
> +PAK_VER    =3D 3
>  =20
>   #########################################################################=
######
>   # Top-level Rules
> @@ -43,7 +43,7 @@ objects =3D $(DL_FILE)
>  =20
>   $(DL_FILE) =3D $(DL_FROM)/$(DL_FILE)
>  =20
> -$(DL_FILE)_MD5 =3D e67b4d842a51b9a453aeeaeed45fb8e1
> +$(DL_FILE)_MD5 =3D 62b49c961043898b43b041dafbc1b389
>  =20
>   install : $(TARGET)
>  =20
>=20

--=20
Sent from my laptop

--===============0387145403160075926==--