From mboxrd@z Thu Jan  1 00:00:00 1970
From: Adolf Belka <adolf.belka@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] Core Update 171: Ship libsodium
Date: Tue, 27 Sep 2022 10:09:36 +0200
Message-ID: <9c35618c-d07b-a8c3-7e98-44e04787b152@ipfire.org>
In-Reply-To: <9cfc2724-69a8-6eed-88ee-7b4a4e19a460@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============9127879382318555718=="
List-Id: <development.lists.ipfire.org>

--===============9127879382318555718==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

Hi Michael,

On 18/09/2022 12:44, Adolf Belka wrote:
> Hi Michael,
>
> On 18/09/2022 11:08, Michael Tremer wrote:
>> Why?
> Because dnsdist has the default for the configure option of 
> --with-libsodium set to auto so in the p[ast dnsdist was built without 
> linking to libsodium. With the introduction of libsodium into the 
> build dnsdist automatically found it and linked to it.
>
> So when libsodium was not shipped then dnsdist fails because it can't 
> find the linked libsodium.so.23 file.
>
> If you don't want to ship libsodium, then the other alternative is 
> that I can raise a patch to add --without-libsodium to the dnsdist 
> configure. That will make it build and run with libsodium being in the 
> build but not in the shipped core packages.
>
> Which way should I do this?
>
Is there a decision made about which option to use?
- Ship libsodium in core IPFire
- Build dnsdist without libsodium

Regards,
Adolf
> Regards,
>
> Adolf.
>>
>>> On 17 Sep 2022, at 23:09, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>>>
>>> Reviewed-by: Adolf Belka <adolf.belka(a)ipfire.org>
>>>
>>> On 17/09/2022 18:53, Peter Müller wrote:
>>>> Fixes: #12929
>>>> Signed-off-by: Peter Müller <peter.mueller(a)ipfire.org>
>>>> ---
>>>> config/rootfiles/core/171/filelists/libsodium | 1 +
>>>> 1 file changed, 1 insertion(+)
>>>> create mode 120000 config/rootfiles/core/171/filelists/libsodium
>>>>
>>>> diff --git a/config/rootfiles/core/171/filelists/libsodium 
>>>> b/config/rootfiles/core/171/filelists/libsodium
>>>> new file mode 120000
>>>> index 000000000..ebd862fbc
>>>> --- /dev/null
>>>> +++ b/config/rootfiles/core/171/filelists/libsodium
>>>> @@ -0,0 +1 @@
>>>> +../../../common/libsodium
>>>> \ No newline at end of file
>>>
>>> -- 
>>> Sent from my laptop
>>

-- 
Sent from my laptop


--===============9127879382318555718==--