From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adolf Belka To: development@lists.ipfire.org Subject: Re: [PATCH] Add column with resolved hostname by IP address Date: Fri, 10 Nov 2023 19:26:53 +0100 Message-ID: <9d761908-ba59-4776-a46c-2e6d2ad12b55@ipfire.org> In-Reply-To: <20231109213641.15840-1-sebastien.gislain@free.fr> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4485744802666734735==" List-Id: --===============4485744802666734735== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Sebastien, Thanks for the patch. I have tested this out and found a few quirks with it. The table for that section is set at 100%. The original columns then added up= to 100%. Your patch added in an additional column at 20% making the total width now 12= 0% but the overall table is still set at 100%. I think you need to adjust the= width of each of the columns including the new column to come to a total of = 100%. In your line for the heading you have a closing tag for a hyperlink but = there is no equivalent opening tag in the line and no hyperlink defined. = I am not sure if this is giving any problems but the closing tag is not = needed there as there is no hyperlink. When evaluating your patch I found that your Hostname column expands to keep = the hostname on one line. This forces the other columns (next-server, filenam= e and root path) to be squeezed up and made into multiple line entries. I thi= nk the hostname column should also be allowed to be a multi line entry to bal= ance the columns up. Eventually the other columns reach a min width and then the table expands out= side of the overall frame of the IPFire page. This may be due to the columns = totalling more than 100% but I am not familiar enough with html coding to be = certain of that. The line if (!$rname || $rname eq "") { $rname =3D $Lang::tr{'lookup failed'}; } has a Language lookup but the phrase 'lookup failed' has not been added into = the English, German or French Language files. Regards, Adolf. On 09/11/2023 22:36, Sebastien GISLAIN wrote: > --- > html/cgi-bin/dhcp.cgi | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/html/cgi-bin/dhcp.cgi b/html/cgi-bin/dhcp.cgi > index f45703f0b..aabf565d7 100755 > --- a/html/cgi-bin/dhcp.cgi > +++ b/html/cgi-bin/dhcp.cgi > @@ -21,6 +21,7 @@ > =20 > use strict; > use experimental 'smartmatch'; > +use IO::Socket; > =20 > # enable only the following on debugging purpose > #use warnings; > @@ -1009,6 +1010,7 @@ print < > $Lang::tr{'mac address'} > $Lang::tr{'ip address'} > + $Lang::tr{'hostname'} > $Lang::tr{'remark'} > next-server<= /b> > filename= > @@ -1106,9 +1108,14 @@ foreach my $line (@current2) { > $TAG4 =3D "class=3D'red'" if ($dhcpsettings{'KEY2'} ne $key); > } > =20 > + # resolved name (if exists) > + my $iaddr =3D inet_aton($temp[1]); > + my $rname =3D gethostbyaddr($iaddr, AF_INET); > + if (!$rname || $rname eq "") { $rname =3D $Lang::tr{'lookup failed'}; } > print < $TAG2$temp[0]$TAG3 > $TAG0$temp[1]$TAG1 > +$rname  > $temp[6]  > $temp[3]  > $temp[4]  --===============4485744802666734735==--