Re: [V2] Backup.cgi: Rework and altering of functionalities and GUI for better usability

Re: [V2] Backup.cgi: Rework and altering of functionalities and GUI for better usability

[Jon Murphy]

[-- Attachment #1: Type: text/plain, Size: 1274 bytes --]

I like it!  "make it so"

Jon

> On May 22, 2021, at 9:53 AM, Matthias Fischer <matthias.fischer(a)ipfire.org> wrote:
> 
> Still based on https://bugzilla.ipfire.org/show_bug.cgi?id=12588
> 
> Hi,
> 
> in the meantime I worked on this - a bit - again. Currently, this CGI is
> running here under Core 156 with no seen problems.
> 
> I've made several changes and adjustments.
> 
> First:
> - I kept the icons - buttons didn't look as I hoped they would. ;-)
> 
> - I kept the old icon order "Download - Delete - Save".
> 
> Changelog:
> - Cleaned up the code a bit, some if-queries were unnessecary (if
> ($cgiparams{'ACTION'} eq...).
> 
> - Therefore, some lang strings became obsolete ('downloadaddon' and
> 'downloadiso'.
> 
> - Separated the ISO files from the IPF files for better overview.
> 
> - Added query for deleting a backup file (onclick=\"return confirm...).
> 
> - Added 'onclick' feature => deleting a file must be acknowledged.
> 
> Biggest change:
> - Added tables - as MT mentioned.
> 
> Details can be seen in the attached screenshots.
> 
> Thoughts? Opinions? I'd like to get some feedback before pushing this... ;-)
> 
> Best,
> Matthias
> 
> <2021-05-22_backup.cgi.png><2021-05-22_backup.cgi_onclick.png>

Re: [V2] Backup.cgi: Rework and altering of functionalities and GUI for better usability

[Michael Tremer]

[-- Attachment #1: Type: text/plain, Size: 1593 bytes --]

Hello,

Could we drop the table borders, please?

We do not have them anywhere in the web UI. Instead we have alternating shades of grey. Can we have those instead?

Best,
-Michael

> On 22 May 2021, at 17:53, Jon Murphy <jcmurphy26(a)gmail.com> wrote:
> 
> I like it!  "make it so"
> 
> Jon
> 
>> On May 22, 2021, at 9:53 AM, Matthias Fischer <matthias.fischer(a)ipfire.org> wrote:
>> 
>> Still based on https://bugzilla.ipfire.org/show_bug.cgi?id=12588
>> 
>> Hi,
>> 
>> in the meantime I worked on this - a bit - again. Currently, this CGI is
>> running here under Core 156 with no seen problems.
>> 
>> I've made several changes and adjustments.
>> 
>> First:
>> - I kept the icons - buttons didn't look as I hoped they would. ;-)
>> 
>> - I kept the old icon order "Download - Delete - Save".
>> 
>> Changelog:
>> - Cleaned up the code a bit, some if-queries were unnessecary (if
>> ($cgiparams{'ACTION'} eq...).
>> 
>> - Therefore, some lang strings became obsolete ('downloadaddon' and
>> 'downloadiso'.
>> 
>> - Separated the ISO files from the IPF files for better overview.
>> 
>> - Added query for deleting a backup file (onclick=\"return confirm...).
>> 
>> - Added 'onclick' feature => deleting a file must be acknowledged.
>> 
>> Biggest change:
>> - Added tables - as MT mentioned.
>> 
>> Details can be seen in the attached screenshots.
>> 
>> Thoughts? Opinions? I'd like to get some feedback before pushing this... ;-)
>> 
>> Best,
>> Matthias
>> 
>> <2021-05-22_backup.cgi.png><2021-05-22_backup.cgi_onclick.png>
> 

Re: [V2] Backup.cgi: Rework and altering of functionalities and GUI for better usability

[Adolf Belka]

[-- Attachment #1: Type: text/plain, Size: 1426 bytes --]

Hi Matthias,

On 22/05/2021 16:53, Matthias Fischer wrote:
> Still based on https://bugzilla.ipfire.org/show_bug.cgi?id=12588
>
> Hi,
>
> in the meantime I worked on this - a bit - again. Currently, this CGI is
> running here under Core 156 with no seen problems.
>
> I've made several changes and adjustments.
>
> First:
> - I kept the icons - buttons didn't look as I hoped they would. ;-)
>
> - I kept the old icon order "Download - Delete - Save".
>
> Changelog:
> - Cleaned up the code a bit, some if-queries were unnessecary (if
> ($cgiparams{'ACTION'} eq...).
>
> - Therefore, some lang strings became obsolete ('downloadaddon' and
> 'downloadiso'.
>
> - Separated the ISO files from the IPF files for better overview.
>
> - Added query for deleting a backup file (onclick=\"return confirm...).
>
> - Added 'onclick' feature => deleting a file must be acknowledged.
>
> Biggest change:
> - Added tables - as MT mentioned.
>
> Details can be seen in the attached screenshots.
>
> Thoughts? Opinions? I'd like to get some feedback before pushing this... ;-)

It looks okay to me. Alternating shades of grey for the rows as mentioned by Michael would also be fine.

Any chance of a diff so I can try it out on a testbed system?

By the way, FYI there is another backup umbrella bug https://bugzilla.ipfire.org/show_bug.cgi?id=11320

Regards,

Adolf.

> Best,
> Matthias
>

Re: [V2] Backup.cgi: Rework and altering of functionalities and GUI for better usability

[Matthias Fischer]

[-- Attachment #1: Type: text/plain, Size: 2108 bytes --]

Hi Adolf,

On 26.05.2021 13:01, Adolf Belka wrote:
> Hi Matthias,
> 
> On 22/05/2021 16:53, Matthias Fischer wrote:
>> Still based on https://bugzilla.ipfire.org/show_bug.cgi?id=12588
>>
>> Hi,
>>
>> in the meantime I worked on this - a bit - again. Currently, this CGI is
>> running here under Core 156 with no seen problems.
>>
>> I've made several changes and adjustments.
>>
>> First:
>> - I kept the icons - buttons didn't look as I hoped they would. ;-)
>>
>> - I kept the old icon order "Download - Delete - Save".
>>
>> Changelog:
>> - Cleaned up the code a bit, some if-queries were unnessecary (if
>> ($cgiparams{'ACTION'} eq...).
>>
>> - Therefore, some lang strings became obsolete ('downloadaddon' and
>> 'downloadiso'.
>>
>> - Separated the ISO files from the IPF files for better overview.
>>
>> - Added query for deleting a backup file (onclick=\"return confirm...).
>>
>> - Added 'onclick' feature => deleting a file must be acknowledged.
>>
>> Biggest change:
>> - Added tables - as MT mentioned.
>>
>> Details can be seen in the attached screenshots.
>>
>> Thoughts? Opinions? I'd like to get some feedback before pushing this... ;-)
> 
> It looks okay to me. Alternating shades of grey for the rows as mentioned by Michael would also be fine.

Nice. Thanks. But...

At the moment I have no idea how to change this CGI to show these
alternating rows. I never did this. For a start I looked into some other
CGIs to get a grip (e.g.: dns, firewall, fwhosts, hosts, services,
wakeonlan, wio and log.dat).
But alternate rows seem to be a bit more complicated to me than the
tables. Hm.
[I'm not an experienced programmer with CGI (call me
"scriptkiddie" ;-) ).]

If everything fails, I'll have to ask for hints how to do this. I'll see
how far I can get.

> Any chance of a diff so I can try it out on a testbed system?

No problem. Work in progress...

> By the way, FYI there is another backup umbrella bug https://bugzilla.ipfire.org/show_bug.cgi?id=11320

I'm aware of this. Not much time these days... ;-)

Best,
Matthias

Re: [V2] Backup.cgi: Rework and altering of functionalities and GUI for better usability

[Adolf Belka]

[-- Attachment #1: Type: text/plain, Size: 2821 bytes --]

Hi Matthias,

On 26/05/2021 17:32, Matthias Fischer wrote:
> Hi Adolf,
> 
> On 26.05.2021 13:01, Adolf Belka wrote:
>> Hi Matthias,
>>
>> On 22/05/2021 16:53, Matthias Fischer wrote:
>>> Still based on https://bugzilla.ipfire.org/show_bug.cgi?id=12588
>>>
>>> Hi,
>>>
>>> in the meantime I worked on this - a bit - again. Currently, this CGI is
>>> running here under Core 156 with no seen problems.
>>>
>>> I've made several changes and adjustments.
>>>
>>> First:
>>> - I kept the icons - buttons didn't look as I hoped they would. ;-)
>>>
>>> - I kept the old icon order "Download - Delete - Save".
>>>
>>> Changelog:
>>> - Cleaned up the code a bit, some if-queries were unnessecary (if
>>> ($cgiparams{'ACTION'} eq...).
>>>
>>> - Therefore, some lang strings became obsolete ('downloadaddon' and
>>> 'downloadiso'.
>>>
>>> - Separated the ISO files from the IPF files for better overview.
>>>
>>> - Added query for deleting a backup file (onclick=\"return confirm...).
>>>
>>> - Added 'onclick' feature => deleting a file must be acknowledged.
>>>
>>> Biggest change:
>>> - Added tables - as MT mentioned.
>>>
>>> Details can be seen in the attached screenshots.
>>>
>>> Thoughts? Opinions? I'd like to get some feedback before pushing this... ;-)
>>
>> It looks okay to me. Alternating shades of grey for the rows as mentioned by Michael would also be fine.
> 
> Nice. Thanks. But...
> 
> At the moment I have no idea how to change this CGI to show these
> alternating rows. I never did this. For a start I looked into some other
> CGIs to get a grip (e.g.: dns, firewall, fwhosts, hosts, services,
> wakeonlan, wio and log.dat).
> But alternate rows seem to be a bit more complicated to me than the
> tables. Hm.
> [I'm not an experienced programmer with CGI (call me
> "scriptkiddie" ;-) ).]
Same here. Join the club. I just have a bit of a passing knowledge of 
the Fixed Leases table in dhcp.cgi
I have been doing some fixes in that table, very slowly, but found out 
about the alternating shades of grey while I was investigating.
If it would be useful I could have a look at that when you provide the diff.
> 
> If everything fails, I'll have to ask for hints how to do this. I'll see
> how far I can get.
> 
>> Any chance of a diff so I can try it out on a testbed system?
> 
> No problem. Work in progress...
> 
>> By the way, FYI there is another backup umbrella bug https://bugzilla.ipfire.org/show_bug.cgi?id=11320
> 
> I'm aware of this. Not much time these days... ;-)
Yes, I can imagine. I am luckier as I am retired, although I have found 
that I still don't have time to do all the things I would like to do but 
enjoying helping with IPFire.

All the best,
Adolf.
> 
> Best,
> Matthias
> 

-- 
Sent from my laptop

Re: [V2] Backup.cgi: Rework and altering of functionalities and GUI for better usability

[Leo Hofmann]

[-- Attachment #1: Type: text/plain, Size: 2735 bytes --]

Hi Matthias,

You can style the table with CSS, you don't have to change anything in the CGI for that.
I did this e.g. in zoneconf.cgi with the "nth-child" selector and it works great:
https://developer.mozilla.org/en-US/docs/Web/CSS/:nth-child
https://git.ipfire.org/?p=ipfire-2.x.git;a=blob;f=html/cgi-bin/zoneconf.cgi;h=62f18e3086cfa1c66ad3be5366083ab6d9e7ae45;hb=refs/heads/master#l90
(In a perfect world, the CSS would not be mixed into the CGI, but hopefully you see how it works)

Best
Leo

Am 26.05.2021 um 17:32 schrieb Matthias Fischer:
> Hi Adolf,
>
> On 26.05.2021 13:01, Adolf Belka wrote:
>> Hi Matthias,
>>
>> On 22/05/2021 16:53, Matthias Fischer wrote:
>>> Still based on https://bugzilla.ipfire.org/show_bug.cgi?id=12588
>>>
>>> Hi,
>>>
>>> in the meantime I worked on this - a bit - again. Currently, this CGI is
>>> running here under Core 156 with no seen problems.
>>>
>>> I've made several changes and adjustments.
>>>
>>> First:
>>> - I kept the icons - buttons didn't look as I hoped they would. ;-)
>>>
>>> - I kept the old icon order "Download - Delete - Save".
>>>
>>> Changelog:
>>> - Cleaned up the code a bit, some if-queries were unnessecary (if
>>> ($cgiparams{'ACTION'} eq...).
>>>
>>> - Therefore, some lang strings became obsolete ('downloadaddon' and
>>> 'downloadiso'.
>>>
>>> - Separated the ISO files from the IPF files for better overview.
>>>
>>> - Added query for deleting a backup file (onclick=\"return confirm...).
>>>
>>> - Added 'onclick' feature => deleting a file must be acknowledged.
>>>
>>> Biggest change:
>>> - Added tables - as MT mentioned.
>>>
>>> Details can be seen in the attached screenshots.
>>>
>>> Thoughts? Opinions? I'd like to get some feedback before pushing this... ;-)
>> It looks okay to me. Alternating shades of grey for the rows as mentioned by Michael would also be fine.
> Nice. Thanks. But...
>
> At the moment I have no idea how to change this CGI to show these
> alternating rows. I never did this. For a start I looked into some other
> CGIs to get a grip (e.g.: dns, firewall, fwhosts, hosts, services,
> wakeonlan, wio and log.dat).
> But alternate rows seem to be a bit more complicated to me than the
> tables. Hm.
> [I'm not an experienced programmer with CGI (call me
> "scriptkiddie" ;-) ).]
>
> If everything fails, I'll have to ask for hints how to do this. I'll see
> how far I can get.
>
>> Any chance of a diff so I can try it out on a testbed system?
> No problem. Work in progress...
>
>> By the way, FYI there is another backup umbrella bug https://bugzilla.ipfire.org/show_bug.cgi?id=11320
> I'm aware of this. Not much time these days... ;-)
>
> Best,
> Matthias