From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] checkrootfiles: exclude update.sh at x86_64 check
Date: Wed, 20 Jul 2022 16:05:38 +0100
Message-ID: <A081FC86-BA2E-4180-959C-224D4677FB70@ipfire.org>
In-Reply-To: <20220719165231.28813-1-arne_f@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3964592051637700628=="
List-Id: <development.lists.ipfire.org>

--===============3964592051637700628==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello,

Is this check the right way to go if the list of exceptions is becoming longe=
r and longer?

-Michael

> On 19 Jul 2022, at 17:52, Arne Fitzenreiter <arne_f(a)ipfire.org> wrote:
>=20
> the updatescript also contains this string so the check
> produce a false positive.
>=20
> Signed-off-by: Arne Fitzenreiter <arne_f(a)ipfire.org>
> ---
> tools/checkrootfiles | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>=20
> diff --git a/tools/checkrootfiles b/tools/checkrootfiles
> index 1a55a4da9..33bfb16e0 100755
> --- a/tools/checkrootfiles
> +++ b/tools/checkrootfiles
> @@ -2,7 +2,7 @@
> ###########################################################################=
####
> #                                                                          =
   #
> # IPFire.org - A linux based firewall                                      =
   #
> -# Copyright (C) 2007-2015  IPFire Team  info(a)ipfire.org                 =
      #
> +# Copyright (C) 2007-2022  IPFire Team  info(a)ipfire.org                 =
      #
> #                                                                          =
   #
> # This program is free software: you can redistribute it and/or modify     =
   #
> # it under the terms of the GNU General Public License as published by     =
   #
> @@ -35,11 +35,13 @@ fi
>=20
> grep -r '/x86_64' ./config/rootfiles/ --exclude gcc --exclude rust-libc \
>     --exclude rust-ppv-lite86 --exclude rust-memchr --exclude *linux* \
> +    --exclude update.sh \
>     --exclude-dir oldcore --exclude-dir x86_64 >/dev/null 2>&1
> if [ "${?}" =3D=3D "0" ]; then
> 	echo "Error! '/x86_64' in rootfiles files found!"
> 	grep -r '/x86_64' ./config/rootfiles/ --exclude gcc --exclude rust-libc \
>     --exclude rust-ppv-lite86 --exclude rust-memchr --exclude *linux* \
> +    --exclude update.sh \
>     --exclude-dir oldcore --exclude-dir x86_64
> 	echo "Replace by xxxMACHINExxx !"
> fi
> --=20
> 2.36.1
>=20


--===============3964592051637700628==--