From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] kernel: enable CONFIG_GCC_PLUGIN_STACKLEAK
Date: Wed, 10 Jun 2020 09:28:47 +0100
Message-ID: <A170CED1-4CCA-4C05-8EA7-0D10B78D3C86@ipfire.org>
In-Reply-To: <286f4067-f7e8-19a2-f45d-204e5e9a6fb1@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2387557169121396926=="
List-Id: <development.lists.ipfire.org>

--===============2387557169121396926==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi,

> On 9 Jun 2020, at 18:53, Peter M=C3=BCller <peter.mueller(a)ipfire.org> wro=
te:
>=20
> Quoted from https://kernsec.org/wiki/index.php/Kernel_Self_Protection_Proje=
ct/Recommended_Settings:
>=20
>> # Wipe stack contents on syscall exit (reduces stale data lifetime in stac=
k)
>> CONFIG_GCC_PLUGIN_STACKLEAK=3Dy
>=20
> Not sure what performance penalities this introduces in real life...

Well, should we not find out before we make this generally available for all =
users?

-Michael

>=20
> Fixes: #12382
>=20
> Cc: Arne Fitzenreiter <arne.fitzenreiter(a)ipfire.org>
> Signed-off-by: Peter M=C3=BCller <peter.mueller(a)ipfire.org>
> ---
> config/kernel/kernel.config.aarch64-ipfire        | 1 +
> config/kernel/kernel.config.armv5tel-ipfire-multi | 1 +
> config/kernel/kernel.config.i586-ipfire           | 1 +
> config/kernel/kernel.config.x86_64-ipfire         | 1 +
> 4 files changed, 4 insertions(+)
>=20
> diff --git a/config/kernel/kernel.config.aarch64-ipfire b/config/kernel/ker=
nel.config.aarch64-ipfire
> index e0f2f6df8..f4240e0ae 100644
> --- a/config/kernel/kernel.config.aarch64-ipfire
> +++ b/config/kernel/kernel.config.aarch64-ipfire
> @@ -256,6 +256,7 @@ CONFIG_HAVE_GCC_PLUGINS=3Dy
> CONFIG_GCC_PLUGINS=3Dy
> # CONFIG_GCC_PLUGIN_CYC_COMPLEXITY is not set
> CONFIG_GCC_PLUGIN_LATENT_ENTROPY=3Dy
> +CONFIG_GCC_PLUGIN_STACKLEAK=3Dy
> CONFIG_GCC_PLUGIN_STRUCTLEAK=3Dy
> CONFIG_GCC_PLUGIN_STRUCTLEAK_BYREF_ALL=3Dy
> # CONFIG_GCC_PLUGIN_STRUCTLEAK_VERBOSE is not set
> diff --git a/config/kernel/kernel.config.armv5tel-ipfire-multi b/config/ker=
nel/kernel.config.armv5tel-ipfire-multi
> index 15183300f..2bcfbdbdd 100644
> --- a/config/kernel/kernel.config.armv5tel-ipfire-multi
> +++ b/config/kernel/kernel.config.armv5tel-ipfire-multi
> @@ -252,6 +252,7 @@ CONFIG_HAVE_GCC_PLUGINS=3Dy
> CONFIG_GCC_PLUGINS=3Dy
> # CONFIG_GCC_PLUGIN_CYC_COMPLEXITY is not set
> CONFIG_GCC_PLUGIN_LATENT_ENTROPY=3Dy
> +CONFIG_GCC_PLUGIN_STACKLEAK=3Dy
> CONFIG_GCC_PLUGIN_STRUCTLEAK=3Dy
> CONFIG_GCC_PLUGIN_STRUCTLEAK_BYREF_ALL=3Dy
> # CONFIG_GCC_PLUGIN_STRUCTLEAK_VERBOSE is not set
> diff --git a/config/kernel/kernel.config.i586-ipfire b/config/kernel/kernel=
.config.i586-ipfire
> index 578931497..a72cde41a 100644
> --- a/config/kernel/kernel.config.i586-ipfire
> +++ b/config/kernel/kernel.config.i586-ipfire
> @@ -283,6 +283,7 @@ CONFIG_HAVE_GCC_PLUGINS=3Dy
> CONFIG_GCC_PLUGINS=3Dy
> # CONFIG_GCC_PLUGIN_CYC_COMPLEXITY is not set
> CONFIG_GCC_PLUGIN_LATENT_ENTROPY=3Dy
> +CONFIG_GCC_PLUGIN_STACKLEAK=3Dy
> CONFIG_GCC_PLUGIN_STRUCTLEAK=3Dy
> CONFIG_GCC_PLUGIN_STRUCTLEAK_BYREF_ALL=3Dy
> # CONFIG_GCC_PLUGIN_STRUCTLEAK_VERBOSE is not set
> diff --git a/config/kernel/kernel.config.x86_64-ipfire b/config/kernel/kern=
el.config.x86_64-ipfire
> index 6a5fbbfe9..cd116d780 100644
> --- a/config/kernel/kernel.config.x86_64-ipfire
> +++ b/config/kernel/kernel.config.x86_64-ipfire
> @@ -293,6 +293,7 @@ CONFIG_HAVE_GCC_PLUGINS=3Dy
> CONFIG_GCC_PLUGINS=3Dy
> # CONFIG_GCC_PLUGIN_CYC_COMPLEXITY is not set
> CONFIG_GCC_PLUGIN_LATENT_ENTROPY=3Dy
> +CONFIG_GCC_PLUGIN_STACKLEAK=3Dy
> CONFIG_GCC_PLUGIN_STRUCTLEAK=3Dy
> CONFIG_GCC_PLUGIN_STRUCTLEAK_BYREF_ALL=3Dy
> # CONFIG_GCC_PLUGIN_STRUCTLEAK_VERBOSE is not set
> --=20
> 2.26.2


--===============2387557169121396926==--