From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Tremer To: development@lists.ipfire.org Subject: Re: UI feedback on latest CU188 nightly build Date: Wed, 21 Aug 2024 15:17:00 +0100 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7191660654972095220==" List-Id: --===============7191660654972095220== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hello, Thank you for this checklist... > On 20 Aug 2024, at 11:13, Adolf Belka wrote: >=20 > Hi Michael, >=20 > Here is the feedback on the UI from the latest nightly build of CU188. >=20 >=20 > On the Intrusion Prevention System WUI page it shows up as running. However= on the Services WUI page the IPS still shows as Stopped. Fixed. Suricata renames itself and so we cannot find a process =E2=80=9Csuric= ata=E2=80=9D any more. > On the IPSec WUI page the Client Connection Status and Control table does n= ot show the status of the connection in colour. This has been fixed on the Op= enVPN WUI page but not yet for the IPSec page. I thought I fixed this before, but I seem to have forgotten the =E2=80=9CDISC= ONNECTED=E2=80=9D state. This is now fixed, too. > On the Firewall Rules WUI page the alternating grey shades are not working = well as the comment lines for each rule entry are being treated as a separate= line to have the shade changed. This would be okay if all rules had remarks = because then the rule line would be one shade and the remark line a different= shade but consistent. Yeah, this is indeed not idea. I have changed this so that it is the way befo= re (by overwriting the automatic striping). > However you can also have a rule without a remark and then the shading swap= s over. Also the remark line should be part of the rule number section. Curre= ntly the remarks are not part of a rule line. See the attached screenshot. Ru= le 1 is a white line and then rule 2, 3 & 4 are grey. The remarks for rules 2= & 3 are on white lines but as rule 4 does not have a remark then the followi= ng rule lines are now white and the remarks are grey. This should now be fixed. > On my vm I have the samba addon installed and it has no colours for the sta= tus of the three daemons on its WUI page. I have used the status widget for this now, too. I have allow refactored the = form to use the new form styling. > I also have WIO and that looks all okay. >=20 > APCUPSD has a WUI page but it uses a compiled cgi page from apcups and won'= t be affected by the changes. Yeah, that external stuff should be entirely unaffected. > The other addons with WUI pages are: >=20 > guardian Guardian had the same service status problem, which I have fixed. > mpfire This thing is so broken that I won=E2=80=99t even touch it. > mympd > tor > transmission > vdr > wlanap >=20 > I just installed guardian and the status part of the table has no colour. I= don't know about the other addons as I have not used them before myself. >=20 > Regards, >=20 > Adolf. >=20 > Okay, I have pushed all those changes now and I will merge next into master t= o get this release on the road=E2=80=A6 We clearly have fixed all the major problems and if there are any more minor = ones, we will catch them during the testing phase. Thank you for your excellent help! -Michael --===============7191660654972095220==--