From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] make.sh: SIGKILL and SIGSTOP cannot be trapped
Date: Wed, 16 Feb 2022 17:25:24 +0000 [thread overview]
Message-ID: <A2679868-92AF-4B9E-A49B-91D8D89ABCB2@ipfire.org> (raw)
In-Reply-To: <761d02cc-e6cb-d6b4-426f-00ebaa993f83@ipfire.org>
[-- Attachment #1: Type: text/plain, Size: 845 bytes --]
Hello,
Is this a cosmetic change or does this fix a real world problem?
-Michael
> On 16 Feb 2022, at 17:24, Peter Müller <peter.mueller(a)ipfire.org> wrote:
>
> There is no sense in instructing "trap" to catch signals it cannot trap
> whatsoever.
>
> Signed-off-by: Peter Müller <peter.mueller(a)ipfire.org>
> ---
> make.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/make.sh b/make.sh
> index 4dd068e4b..c06b4ec38 100755
> --- a/make.sh
> +++ b/make.sh
> @@ -437,7 +437,7 @@ prepareenv() {
> fi
>
> # Trap on emergency exit
> - trap "exiterror 'Build process interrupted'" SIGINT SIGTERM SIGKILL SIGSTOP SIGQUIT
> + trap "exiterror 'Build process interrupted'" SIGINT SIGTERM SIGQUIT
>
> # Checking if running as root user
> if [ $(id -u) -ne 0 ]; then
> --
> 2.34.1
next prev parent reply other threads:[~2022-02-16 17:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-16 17:24 Peter Müller
2022-02-16 17:25 ` Michael Tremer [this message]
2022-02-16 17:27 ` Peter Müller
2022-02-16 17:29 ` Michael Tremer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A2679868-92AF-4B9E-A49B-91D8D89ABCB2@ipfire.org \
--to=michael.tremer@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox