From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] make.sh: SIGKILL and SIGSTOP cannot be trapped
Date: Wed, 16 Feb 2022 17:25:24 +0000
Message-ID: <A2679868-92AF-4B9E-A49B-91D8D89ABCB2@ipfire.org>
In-Reply-To: <761d02cc-e6cb-d6b4-426f-00ebaa993f83@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4236136145256790194=="
List-Id: <development.lists.ipfire.org>

--===============4236136145256790194==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello,

Is this a cosmetic change or does this fix a real world problem?

-Michael

> On 16 Feb 2022, at 17:24, Peter M=C3=BCller <peter.mueller(a)ipfire.org> wr=
ote:
>=20
> There is no sense in instructing "trap" to catch signals it cannot trap
> whatsoever.
>=20
> Signed-off-by: Peter M=C3=BCller <peter.mueller(a)ipfire.org>
> ---
> make.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/make.sh b/make.sh
> index 4dd068e4b..c06b4ec38 100755
> --- a/make.sh
> +++ b/make.sh
> @@ -437,7 +437,7 @@ prepareenv() {
> 	fi
>=20
> 	# Trap on emergency exit
> -	trap "exiterror 'Build process interrupted'" SIGINT SIGTERM SIGKILL SIGST=
OP SIGQUIT
> +	trap "exiterror 'Build process interrupted'" SIGINT SIGTERM SIGQUIT
>=20
> 	# Checking if running as root user
> 	if [ $(id -u) -ne 0 ]; then
> --=20
> 2.34.1


--===============4236136145256790194==--