Re: [PATCH] media.cgi: Changed topic format for 'Inodes' and 'transfers'

[Michael Tremer <michael.tremer@ipfire.org>]

[-- Attachment #1: Type: text/plain, Size: 1491 bytes --]



> On 13 May 2020, at 16:17, Matthias Fischer <matthias.fischer(a)ipfire.org> wrote:
> 
> Changed from <h3> to <h2>.
> 
> Both entries are now underlined and fit better into the context - IMHO.
> 
> Signed-off-by: Matthias Fischer <matthias.fischer(a)ipfire.org>
> ---
> html/cgi-bin/media.cgi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/html/cgi-bin/media.cgi b/html/cgi-bin/media.cgi
> index 7ef6905bd..73b6f7da9 100644
> --- a/html/cgi-bin/media.cgi
> +++ b/html/cgi-bin/media.cgi
> @@ -106,7 +106,7 @@ END
> 		}
> 	}
> 	close DF;
> -	print "<tr><td colspan='7'>&nbsp;\n<tr><td colspan='7'><h3>Inodes</h3>\n";
> +	print "<tr><td colspan='7'>&nbsp;\n<tr><td colspan='7'><h2>Inodes</h2>\n";

Inodes is a string that should be translated, too.

> 
> 	open(DF,'/bin/df -P -i -x rootfs|');
> 	while(<DF>){
> @@ -147,7 +147,7 @@ END
> 	my @iostat1 = qx(/usr/bin/iostat -dm -p | grep -v "Linux" | awk '{print \$1}');
> 	my @iostat2 = qx(/usr/bin/iostat -dm -p | grep -v "Linux" | awk '{print \$5}');
> 	my @iostat3 = qx(/usr/bin/iostat -dm -p | grep -v "Linux" | awk '{print \$6}');
> -	print "<tr><td colspan='3'>&nbsp;\n<tr><td colspan='3'><h3>$Lang::tr{'transfers}</h3></td></tr>";
> +	print "<tr><td colspan='3'>&nbsp;\n<tr><td colspan='3'><h2>$Lang::tr{'transfers}</h2></td></tr>";

You have a syntax error here due to a missing ‘.

> 	my $i=0;
> 
> 	for(my $i = 1; $i <= $#iostat1; $i++){
> -- 
> 2.17.1
>