From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject:
 Re: [PATCH] media.cgi: Changed topic format for 'Inodes' and 'transfers'
Date: Wed, 13 May 2020 16:52:19 +0100
Message-ID: <A2764B8A-E6E9-4D79-B336-7360CCC24965@ipfire.org>
In-Reply-To: <20200513151721.31363-1-matthias.fischer@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0046267474836196823=="
List-Id: <development.lists.ipfire.org>

--===============0046267474836196823==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable



> On 13 May 2020, at 16:17, Matthias Fischer <matthias.fischer(a)ipfire.org> =
wrote:
>=20
> Changed from <h3> to <h2>.
>=20
> Both entries are now underlined and fit better into the context - IMHO.
>=20
> Signed-off-by: Matthias Fischer <matthias.fischer(a)ipfire.org>
> ---
> html/cgi-bin/media.cgi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/html/cgi-bin/media.cgi b/html/cgi-bin/media.cgi
> index 7ef6905bd..73b6f7da9 100644
> --- a/html/cgi-bin/media.cgi
> +++ b/html/cgi-bin/media.cgi
> @@ -106,7 +106,7 @@ END
> 		}
> 	}
> 	close DF;
> -	print "<tr><td colspan=3D'7'>&nbsp;\n<tr><td colspan=3D'7'><h3>Inodes</h3=
>\n";
> +	print "<tr><td colspan=3D'7'>&nbsp;\n<tr><td colspan=3D'7'><h2>Inodes</h2=
>\n";

Inodes is a string that should be translated, too.

>=20
> 	open(DF,'/bin/df -P -i -x rootfs|');
> 	while(<DF>){
> @@ -147,7 +147,7 @@ END
> 	my @iostat1 =3D qx(/usr/bin/iostat -dm -p | grep -v "Linux" | awk '{print =
\$1}');
> 	my @iostat2 =3D qx(/usr/bin/iostat -dm -p | grep -v "Linux" | awk '{print =
\$5}');
> 	my @iostat3 =3D qx(/usr/bin/iostat -dm -p | grep -v "Linux" | awk '{print =
\$6}');
> -	print "<tr><td colspan=3D'3'>&nbsp;\n<tr><td colspan=3D'3'><h3>$Lang::tr{=
'transfers}</h3></td></tr>";
> +	print "<tr><td colspan=3D'3'>&nbsp;\n<tr><td colspan=3D'3'><h2>$Lang::tr{=
'transfers}</h2></td></tr>";

You have a syntax error here due to a missing =E2=80=98.

> 	my $i=3D0;
>=20
> 	for(my $i =3D 1; $i <=3D $#iostat1; $i++){
> --=20
> 2.17.1
>=20


--===============0046267474836196823==--