From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Tremer To: development@lists.ipfire.org Subject: Re: [PATCH] vulnerabilities.cgi: Use orange instead of blue for mitigated issues Date: Tue, 11 Jun 2019 10:37:02 +0100 Message-ID: In-Reply-To: <7f63ca30-c3cf-e697-4b54-b8669aacc6ef@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1892250338847012787==" List-Id: --===============1892250338847012787== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hello, I would like to say that I disagree with this change. Not because I think that the mitigations are good enough. It is a little bit = more complex: * I do not think that we can generally say that mitigations are bad. Some are= pretty much solid fixes. Some are quite the opposite. That means that some s= hould be rather green and some others should be rather red. Making them all o= range is not suitable from my point of view. * I do not want to scare our users. Yes, their hardware might be broken. But = there is no point in changing this now with something very similar. There is = no good hardware out there that performs at the same time. I do not want to s= pread the view that IPFire is only broken because we show this information. Therefore I am kind of okay with the blue. It does not really send a message.= The message is complex. I could write half a book about it. What are other people=E2=80=99s views on this? -Michael > On 10 Jun 2019, at 20:24, Peter M=C3=BCller wr= ote: >=20 > A mitigated (CPU) vulnerability is still present and might be just > harder to exploit. Using blue as colour for them does not illustrate > their dangerousness - orange is a better choice as far as I am > concerned. >=20 > Scaring people away from Intel processors will be a completely > unintended side effect. :-) >=20 > Signed-off-by: Peter M=C3=BCller > --- > html/cgi-bin/vulnerabilities.cgi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/html/cgi-bin/vulnerabilities.cgi b/html/cgi-bin/vulnerabilitie= s.cgi > index a8746c30c..21d963618 100644 > --- a/html/cgi-bin/vulnerabilities.cgi > +++ b/html/cgi-bin/vulnerabilities.cgi > @@ -129,7 +129,7 @@ for my $vuln (sort keys %VULNERABILITIES) { > } elsif ($status eq "Mitigation") { > $status_message =3D $Lang::tr{'mitigated'}; > $colour =3D "white"; > - $bgcolour =3D ${Header::colourblue}; > + $bgcolour =3D ${Header::colourorange}; >=20 > # Unknown report from kernel > } else { > --=20 > 2.16.4 --===============1892250338847012787==--