From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Tremer To: development@lists.ipfire.org Subject: Re: DDNS: add new Provider key-sytems.net (domaindiscount24) Date: Thu, 28 Nov 2019 13:35:42 +0000 Message-ID: In-Reply-To: <23d7d16f-1098-13d0-152a-651c4ff6d50a@gmx.at> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8706268506736420994==" List-Id: --===============8706268506736420994== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi, Thanks for testing this. Looks like I was very wrong here. > On 28 Nov 2019, at 13:03, Christof Weniger wrote: >=20 > Hello Michael, >=20 > after change to DynDNS class I got the following "DDNSUpdateError" > Nov 28 13:42:17 minusrouter ddns[23192]: Dynamic DNS update for ovpn.XXXXX.= YYY (dynamicdns.key-systems.net) failed: > Nov 28 13:42:17 minusrouter ddns[23192]: DDNSUpdateError: The update coul= d not be performed > Nov 28 13:42:17 minusrouter ddns[23192]: Server response: [RESPONSE] code= =3D 200 description =3D Command completed successfully queuetime =3D 0 runti= me =3D 0.058 EOF=20 >=20 > The DynDNS2 code (generating the ERROR): > class DDNSProviderKEYSYSTEMS(DDNSProtocolDynDNS2, DDNSProvider): > handle =3D "dynamicdns.key-systems.net" > name =3D "dynamicdns.key-systems.net" > website =3D=20 > "https://domaindiscount24.com/" >=20 > #protocols =3D ("ipv4",) >=20 > # There are only information provided by the domaindiscount24 how to > # perform an update with HTTP APIs > #=20 > https://www.domaindiscount24.com/faq/dynamic-dns >=20 > # examples:=20 > https://dynamicdns.key-systems.net/update.php?hostname=3Dhostname&password= =3Dpassword&ip=3Dauto >=20 > # =20 > https://dynamicdns.key-systems.net/update.php?hostname=3Dhostname&password= =3Dpassword&ip=3D213.x.x.x&mx=3D213.x.x.x >=20 >=20 > url =3D=20 > "https://dynamicdns.key-systems.net/update.php" >=20 >=20 > def prepare_request_data(self, proto): > address =3D self.get_address(proto) > data =3D { > "hostname" : self.hostname, > "password" : self.password, > "ip" : address, > "mx" : address, I wouldn=E2=80=99t set the MX record here. First of all it should not contain= an IP address and so it can be statically configured. I consider this being = outside of the scope of ddns. > } >=20 > return data >=20 >=20 > The server response to a simple wget request was: > [RESPONSE] > code =3D 200 > description =3D Command completed successfully > queuetime =3D 0 > runtime =3D 0.053 > EOF >=20 >=20 > The working code: >=20 > class DDNSProviderKEYSYSTEMS(DDNSProvider): > handle =3D "dynamicdns.key-systems.net" > name =3D "dynamicdns.key-systems.net" > website =3D=20 > "https://domaindiscount24.com/" >=20 > protocols =3D ("ipv4",) >=20 > # There are only information provided by the domaindiscount24 how to > # perform an update with HTTP APIs > #=20 > https://www.domaindiscount24.com/faq/dynamic-dns >=20 > # examples:=20 > https://dynamicdns.key-systems.net/update.php?hostname=3Dhostname&password= =3Dpassword&ip=3Dauto >=20 > # =20 > https://dynamicdns.key-systems.net/update.php?hostname=3Dhostname&password= =3Dpassword&ip=3D213.x.x.x&mx=3D213.x.x.x >=20 >=20 > url =3D=20 > "https://dynamicdns.key-systems.net/update.php" >=20 > can_remove_records =3D False >=20 > #def prepare_request_data(self, proto): > def update_protocol(self, proto): > address =3D self.get_address(proto) > data =3D { > "hostname" : self.hostname, > "password" : self.password, > "ip" : address, > "mx" : address, See above. > } >=20 > # Send update to the server. > response =3D self.send_request(self.url, data=3Ddata) >=20 > # Handle success messages. > if response.code =3D=3D 200: > return This is just very vage. >=20 > # If we got here, some other update error happened. > raise DDNSUpdateError There must be other responses - one might hope. Did you check sending an incorrect password and do you get 401 or 403 at leas= t? >=20 > #return data >=20 >=20 >> Unfortunately this provider has no list of any possible responses - or may= be I have overlooked it. That can however be tested to check if those are sti= ll compatible with DynDNS. > I couldn't find any more pointers on the providers page either, and for tha= t testing I would have to dig in too deep (into the code and the protocols) f= or me to handle at the moment. (maybe next week/month). Yes, so great to not have any documentation=E2=80=A6=20 -Michael >=20 >=20 > best > Christof >=20 > On 28/11/2019 12:20, Michael Tremer wrote: >> Hello Christof, >>=20 >>=20 >>> On 28 Nov 2019, at 10:45, Christof Weniger >>> wrote: >>>=20 >>> Hi, >>>=20 >>> I hope this is the correct way to submit this patch. >>>=20 >> Yes, you found the right place. >>=20 >> It would have been better to post the patch inline (and not as an attachme= nt), so that I could have commented on it. >>=20 >>=20 >>> https://www.domaindiscount24.com/ >>> has its own ddns service runnning, >>> which (for me) gets rid of the necessity of having to use an extra >>> service for that. >>>=20 >>> I tested the following patch on my system at home, and attached it to >>> this mail. >>>=20 >>> I started my quest at the community forum: >>>=20 >>> https://community.ipfire.org/t/adding-new-ddns-provider/428/2 >>>=20 >>>=20 >>> Christof >>>=20 >>>=20 >>>=20 >>>=20 >>>=20 >>> >>>=20 >> I will make an exception here now and still give you my thoughts :) >>=20 >> It looks like this is very close to the DynDNS protocol, so you can re-use= that as some other providers do. >>=20 >> Unfortunately this provider has no list of any possible responses - or may= be I have overlooked it. That can however be tested to check if those are sti= ll compatible with DynDNS. >>=20 >> Finally, you are setting the IP addresses to =E2=80=9Cauto=E2=80=9D which = probably is not a good idea. I would prefer that it is explicitly being set. = There is a function for it that finds out which one is the correct IP address. >>=20 >> In the end I think this provider could look like =E2=80=9Cmyonlineportal= =E2=80=9D:=20 >> https://git.ipfire.org/?p=3Dddns.git;a=3Dblob;f=3Dsrc/ddns/providers.py;h= =3D661fbcc57a5aecba0d958ec05c26296b3cef0d70;hb=3DHEAD#l1274 >>=20 >>=20 >> Best, >> -Michael >>=20 >=20 --===============8706268506736420994==--