From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] system.cgi: properly translate load average graph
Date: Mon, 27 Apr 2020 16:48:32 +0100 [thread overview]
Message-ID: <A5FA199F-F1CA-4CA9-BF99-A069D79B35A4@ipfire.org> (raw)
In-Reply-To: <ce11e44c-23bf-6bfb-1cc3-5ecd5f4d0dfa@ipfire.org>
[-- Attachment #1: Type: text/plain, Size: 1577 bytes --]
Hi,
> On 27 Apr 2020, at 16:37, Peter Müller <peter.mueller(a)ipfire.org> wrote:
>
> Signed-off-by: Peter Müller <peter.mueller(a)ipfire.org>
> ---
> config/cfgroot/graphs.pl | 2 +-
> html/cgi-bin/system.cgi | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/config/cfgroot/graphs.pl b/config/cfgroot/graphs.pl
> index 1bed49fa3..928a74cfb 100644
> --- a/config/cfgroot/graphs.pl
> +++ b/config/cfgroot/graphs.pl
> @@ -256,7 +256,7 @@ sub updateloadgraph {
> "-1".$period,
> "-l 0",
> "-r",
> - "-t Load Average ".$Lang::tr{'graph per'}." ".$Lang::tr{$period."-graph"},
> + "-t ".$Lang::tr{'uptime load average'}." ".$Lang::tr{'graph per'}." ".$Lang::tr{$period."-graph"},
> "-v ".$Lang::tr{'processes'},
> "--color=SHADEA".$color{"color19"},
> "--color=SHADEB".$color{"color19"},
> diff --git a/html/cgi-bin/system.cgi b/html/cgi-bin/system.cgi
> index 487ba996c..2c83f1e81 100644
> --- a/html/cgi-bin/system.cgi
> +++ b/html/cgi-bin/system.cgi
> @@ -66,7 +66,7 @@ if ( $querry[0] =~ "cpufreq"){
> &Header::closebox();
> }
>
> - &Header::openbox('100%', 'center', "Load $Lang::tr{'graph'}");
> + &Header::openbox('100%', 'center', "$Lang::tr{'uptime load average'} $Lang::tr{'graph'}");
You are concatenating two strings here. This might work in English, but not in other languages.
So the correct way would be to have “uptime load average graph” as one string.
Best,
-Michael
> &Graphs::makegraphbox("system.cgi","load","day");
> &Header::closebox();
>
> --
> 2.16.4
next prev parent reply other threads:[~2020-04-27 15:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-27 15:37 Peter Müller
2020-04-27 15:48 ` Michael Tremer [this message]
2020-04-27 16:11 ` Peter Müller
2020-04-27 20:57 ` Michael Tremer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A5FA199F-F1CA-4CA9-BF99-A069D79B35A4@ipfire.org \
--to=michael.tremer@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox