From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] system.cgi: properly translate load average graph
Date: Mon, 27 Apr 2020 16:48:32 +0100
Message-ID: <A5FA199F-F1CA-4CA9-BF99-A069D79B35A4@ipfire.org>
In-Reply-To: <ce11e44c-23bf-6bfb-1cc3-5ecd5f4d0dfa@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1347520584369994015=="
List-Id: <development.lists.ipfire.org>

--===============1347520584369994015==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi,

> On 27 Apr 2020, at 16:37, Peter M=C3=BCller <peter.mueller(a)ipfire.org> wr=
ote:
>=20
> Signed-off-by: Peter M=C3=BCller <peter.mueller(a)ipfire.org>
> ---
> config/cfgroot/graphs.pl | 2 +-
> html/cgi-bin/system.cgi  | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/config/cfgroot/graphs.pl b/config/cfgroot/graphs.pl
> index 1bed49fa3..928a74cfb 100644
> --- a/config/cfgroot/graphs.pl
> +++ b/config/cfgroot/graphs.pl
> @@ -256,7 +256,7 @@ sub updateloadgraph {
> 		"-1".$period,
> 		"-l 0",
> 		"-r",
> -		"-t Load Average ".$Lang::tr{'graph per'}." ".$Lang::tr{$period."-graph"=
},
> +		"-t ".$Lang::tr{'uptime load average'}." ".$Lang::tr{'graph per'}." ".$L=
ang::tr{$period."-graph"},
> 		"-v ".$Lang::tr{'processes'},
> 		"--color=3DSHADEA".$color{"color19"},
> 		"--color=3DSHADEB".$color{"color19"},
> diff --git a/html/cgi-bin/system.cgi b/html/cgi-bin/system.cgi
> index 487ba996c..2c83f1e81 100644
> --- a/html/cgi-bin/system.cgi
> +++ b/html/cgi-bin/system.cgi
> @@ -66,7 +66,7 @@ if ( $querry[0] =3D~ "cpufreq"){
> 		&Header::closebox();
> 	}
>=20
> -	&Header::openbox('100%', 'center', "Load $Lang::tr{'graph'}");
> +	&Header::openbox('100%', 'center', "$Lang::tr{'uptime load average'} $Lan=
g::tr{'graph'}");

You are concatenating two strings here. This might work in English, but not i=
n other languages.

So the correct way would be to have =E2=80=9Cuptime load average graph=E2=80=
=9D as one string.

Best,
-Michael

> 	&Graphs::makegraphbox("system.cgi","load","day");
> 	&Header::closebox();
>=20
> --=20
> 2.16.4


--===============1347520584369994015==--