Re: [PATCH] jquery: Update to 3.6.0

[Michael Tremer <michael.tremer@ipfire.org>]

[-- Attachment #1: Type: text/plain, Size: 3297 bytes --]

Thanks for the feedback, I will merge this patch :)

-Michael

> On 18 Mar 2021, at 19:32, Leo Hofmann <hofmann(a)leo-andres.de> wrote:
> 
> Hi Adolf,
> 
> thank you very much for getting this done so quickly!
> 
> I have updated jQuery on my test system and could not find any immediate issues. My Firefox 86 did not complain, the speedmeter and firewall GUI are working.
> As far as I can tell, none of the affected funtions are used anywhere.
> 
> Best regards,
> Leo
> 
> Am 17.03.2021 um 22:48 schrieb Adolf Belka:
>> Hi All,
>> 
>> This patch for jquery has very significant changes. It has changed from Branch 1 to 2 to 3. The change from Branch 2 to 3 lists several breaking changes.
>> I have no familiarity with jquery so cannot tell if these changes could give a problem or not to IPFire.
>> 
>> It would be good for someone familiar with the use of jquery in IPFire to test this patch to check if it is okay or creates a problem.
>> 
>> Regards,
>> Adolf.
>> 
>> 
>> On 17/03/2021 22:42, Adolf Belka wrote:
>>> - Update from 1.10.2 to 3.6.0
>>> - No update required for rootfile
>>> - Changelog covers 8 years and 3 branches of code version
>>> - The 1.x and 2.x branches no longer receive patches
>>>     Summary of Important Changes for move to 3.0
>>>      Attributes
>>>          Breaking change: .removeAttr() no longer sets properties to false
>>>          Breaking change: select-multiple with nothing selected returns an empty array
>>>          Feature: SVG documents support class operations
>>>          Deprecated: .toggleClass() with no arguments and .toggleClass( Boolean )
>>>      Callbacks
>>>          Feature: Locking a Callback prevents only future list execution
>>>      Core
>>>          Breaking change: jQuery 3.0 runs in Strict Mode
>>>          Breaking change: document-ready handlers are now asynchronous
>>>          Breaking change: jQuery.isNumeric() and custom .toString()
>>>          Breaking change: Deprecated .context and .selector properties removed
>>>          Breaking change: Deprecated .size() removed
>>>          Breaking change: Undocumented internal methods no longer exposed
>>>          Breaking change: Return values on empty sets are undefined
>>>          Feature: for...of loops can be used on jQuery collections
>>>          Feature: jQuery.ready promise is formally supported
>>>          Deprecated: jQuery.unique(), renamed to jQuery.uniqueSort()
>>>          Deprecated: jQuery.parseJSON()
>>>          Deprecated: document-ready handlers other than jQuery(function)
>>> 
>>> Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
>>> ---
>>>   lfs/jquery | 4 ++--
>>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>> 
>>> diff --git a/lfs/jquery b/lfs/jquery
>>> index 6b054cbd4..1d35bbedd 100644
>>> --- a/lfs/jquery
>>> +++ b/lfs/jquery
>>> @@ -24,7 +24,7 @@
>>>     include Config
>>>   -VER        = 1.10.2
>>> +VER        = 3.6.0
>>>     THISAPP    = jquery-$(VER)
>>>   DL_FILE    = $(THISAPP).min.js
>>> @@ -40,7 +40,7 @@ objects = $(DL_FILE)
>>>     $(DL_FILE) = $(DL_FROM)/$(DL_FILE)
>>>   -$(DL_FILE)_MD5 = 628072e7212db1e8cdacb22b21752cda
>>> +$(DL_FILE)_MD5 = 8fb8fee4fcc3cc86ff6c724154c49c42
>>>     install : $(TARGET)
>>> 
>>