From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] jquery: Update to 3.6.0
Date: Fri, 19 Mar 2021 09:59:24 +0000
Message-ID: <A7C59821-36BB-4B73-9169-A951932E7D59@ipfire.org>
In-Reply-To: <caec9204-ce98-6ee8-2750-a9138cedf7e7@leo-andres.de>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8258573150916397951=="
List-Id: <development.lists.ipfire.org>

--===============8258573150916397951==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Thanks for the feedback, I will merge this patch :)

-Michael

> On 18 Mar 2021, at 19:32, Leo Hofmann <hofmann(a)leo-andres.de> wrote:
>=20
> Hi Adolf,
>=20
> thank you very much for getting this done so quickly!
>=20
> I have updated jQuery on my test system and could not find any immediate is=
sues. My Firefox 86 did not complain, the speedmeter and firewall GUI are wor=
king.
> As far as I can tell, none of the affected funtions are used anywhere.
>=20
> Best regards,
> Leo
>=20
> Am 17.03.2021 um 22:48 schrieb Adolf Belka:
>> Hi All,
>>=20
>> This patch for jquery has very significant changes. It has changed from Br=
anch 1 to 2 to 3. The change from Branch 2 to 3 lists several breaking change=
s.
>> I have no familiarity with jquery so cannot tell if these changes could gi=
ve a problem or not to IPFire.
>>=20
>> It would be good for someone familiar with the use of jquery in IPFire to =
test this patch to check if it is okay or creates a problem.
>>=20
>> Regards,
>> Adolf.
>>=20
>>=20
>> On 17/03/2021 22:42, Adolf Belka wrote:
>>> - Update from 1.10.2 to 3.6.0
>>> - No update required for rootfile
>>> - Changelog covers 8 years and 3 branches of code version
>>> - The 1.x and 2.x branches no longer receive patches
>>>     Summary of Important Changes for move to 3.0
>>>      Attributes
>>>          Breaking change: .removeAttr() no longer sets properties to false
>>>          Breaking change: select-multiple with nothing selected returns a=
n empty array
>>>          Feature: SVG documents support class operations
>>>          Deprecated: .toggleClass() with no arguments and .toggleClass( B=
oolean )
>>>      Callbacks
>>>          Feature: Locking a Callback prevents only future list execution
>>>      Core
>>>          Breaking change: jQuery 3.0 runs in Strict Mode
>>>          Breaking change: document-ready handlers are now asynchronous
>>>          Breaking change: jQuery.isNumeric() and custom .toString()
>>>          Breaking change: Deprecated .context and .selector properties re=
moved
>>>          Breaking change: Deprecated .size() removed
>>>          Breaking change: Undocumented internal methods no longer exposed
>>>          Breaking change: Return values on empty sets are undefined
>>>          Feature: for...of loops can be used on jQuery collections
>>>          Feature: jQuery.ready promise is formally supported
>>>          Deprecated: jQuery.unique(), renamed to jQuery.uniqueSort()
>>>          Deprecated: jQuery.parseJSON()
>>>          Deprecated: document-ready handlers other than jQuery(function)
>>>=20
>>> Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
>>> ---
>>>   lfs/jquery | 4 ++--
>>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>>=20
>>> diff --git a/lfs/jquery b/lfs/jquery
>>> index 6b054cbd4..1d35bbedd 100644
>>> --- a/lfs/jquery
>>> +++ b/lfs/jquery
>>> @@ -24,7 +24,7 @@
>>>     include Config
>>>   -VER        =3D 1.10.2
>>> +VER        =3D 3.6.0
>>>     THISAPP    =3D jquery-$(VER)
>>>   DL_FILE    =3D $(THISAPP).min.js
>>> @@ -40,7 +40,7 @@ objects =3D $(DL_FILE)
>>>     $(DL_FILE) =3D $(DL_FROM)/$(DL_FILE)
>>>   -$(DL_FILE)_MD5 =3D 628072e7212db1e8cdacb22b21752cda
>>> +$(DL_FILE)_MD5 =3D 8fb8fee4fcc3cc86ff6c724154c49c42
>>>     install : $(TARGET)
>>>=20
>>=20


--===============8258573150916397951==--