public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH 1/2] Added x86_64 i586 aarch64 armv5tel support for GO language required for node_exporter compilation.
Date: Tue, 08 Jun 2021 17:54:07 +0100	[thread overview]
Message-ID: <A924FEED-78FF-44F0-961E-46A65CDA2CE3@ipfire.org> (raw)
In-Reply-To: <20210606174856.177205-2-holger.sunke@posteo.de>

[-- Attachment #1: Type: text/plain, Size: 1935 bytes --]

Hello Holger,

This patch looks good so far, but the root files are missing.

Do you know what those are?

Otherwise this would be mergeable.

Best,
-Michael

> On 6 Jun 2021, at 18:48, Holger Sunke <holger.sunke(a)posteo.de> wrote:
> 
> ---
> lfs/Config | 8 ++++++++
> lfs/go     | 9 ++++++---
> 2 files changed, 14 insertions(+), 3 deletions(-)
> 
> diff --git a/lfs/Config b/lfs/Config
> index 7d98e303b..c8be227a1 100644
> --- a/lfs/Config
> +++ b/lfs/Config
> @@ -138,6 +138,14 @@ ifeq "$(BUILD_ARCH)" "aarch64"
> 	GOARCH = arm64
> endif
> 
> +ifeq "$(BUILD_ARCH)" "armv5tel"
> +	GOARCH = armv6l
> +endif
> +
> +ifeq "$(BUILD_ARCH)" "i586"
> +	GOARCH = 386
> +endif
> +
> ###############################################################################
> # Common Macro Definitions
> ###############################################################################
> diff --git a/lfs/go b/lfs/go
> index 6ebb37080..487ad8486 100644
> --- a/lfs/go
> +++ b/lfs/go
> @@ -28,10 +28,10 @@ VER        = 1.15.4
> 
> THISAPP    = go-$(VER)
> DL_FILE    = go$(VER).$(GOOS)-$(GOARCH).tar.gz
> -DL_FROM    = $(URL_IPFIRE)
> +DL_FROM    = https://golang.org/dl/
> DIR_APP    = $(DIR_SRC)/go
> TARGET     = $(DIR_INFO)/$(THISAPP)
> -SUP_ARCH   = x86_64
> +SUP_ARCH   = x86_64 i586 aarch64 armv5tel
> 
> ###############################################################################
> # Top-level Rules
> @@ -41,7 +41,10 @@ objects = $(DL_FILE)
> 
> $(DL_FILE) = $(DL_FROM)/$(DL_FILE)
> 
> -$(DL_FILE)_MD5 = 8e9d11a16f03372c82c5134278a0bd7d
> +go$(VER).$(GOOS)-amd64.tar.gz_MD5 = 8e9d11a16f03372c82c5134278a0bd7d
> +go$(VER).$(GOOS)-386.tar.gz_MD5 = 8d1c3539c88710273f61b0c810b7448c
> +go$(VER).$(GOOS)-arm64.tar.gz_MD5 = b1846fb093f0261707bda44e158bc5be
> +go$(VER).$(GOOS)-armv6l.tar.gz_MD5 = cf04e0d84de6cbb7d224be1f42a83f02
> 
> install : $(TARGET)
> 
> -- 
> 2.30.2
> 


  reply	other threads:[~2021-06-08 16:54 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-06 17:48 [PATCH 0/2] Reworked patches introducing node_exporter on master branch Holger Sunke
2021-06-06 17:48 ` [PATCH 1/2] Added x86_64 i586 aarch64 armv5tel support for GO language required for node_exporter compilation Holger Sunke
2021-06-08 16:54   ` Michael Tremer [this message]
2021-06-09  6:00     ` Holger Sunke
2021-06-10  8:57       ` Michael Tremer
2021-07-15 19:32     ` Holger Sunke
2021-07-19 11:11       ` Michael Tremer
2021-07-21 17:55         ` Holger Sunke
2021-07-21 18:15           ` Michael Tremer
2021-07-24 19:13             ` Holger Sunke
2021-07-26 14:09               ` Michael Tremer
2021-06-06 17:48 ` [PATCH 2/2] Added new node_exporter package Holger Sunke
2021-06-08 16:56   ` Michael Tremer
2021-06-09  6:14     ` Holger Sunke
2021-06-10  9:03       ` Michael Tremer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=A924FEED-78FF-44F0-961E-46A65CDA2CE3@ipfire.org \
    --to=michael.tremer@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox