From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Tremer To: development@lists.ipfire.org Subject: Re: [PATCH] brutally tell ignorant Vim not to indent Python scripts with spaces Date: Fri, 13 Nov 2020 14:09:02 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8879477867700289045==" List-Id: --===============8879477867700289045== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi, I hope you have calmed down by now. *Pushing over a glass of whisky* I totally agree with this. I kind of get what they tried to achieve here but = unfortunately that didn=E2=80=99t work. But I think other editors get their d= efault configuration very very wrong too. Why do I need to enable basic featu= res? I am looking at you - nano. > On 11 Nov 2020, at 16:02, Peter M=C3=BCller wr= ote: >=20 > This patch brutally overwrites the default vimrc file located at > /usr/share/vim/vim81/defaults.vim (at the time of writing) in order to > tell Vim it must not indent Python scripts with spaces. >=20 > Since we have agreed on indenting Python scripts with tabs (the PEP8 > standard does not give a very plausible explanation why spaces are better > than tabs, anyway - but hey, those are the experts [tm], and who are we > to question their decisions?!), the auto-indention of Vim has been an > ongoing nuisance: >=20 > Instead of even trying to be smart and checking the indention type of > the source code lines before, it just expands tabs to spaces by default, > rendering Python scripts with tabulators as indention unusable as soon > as any additional line is inserted. Ultimately, using nano as a quick > workaround "solved" the problem, but makes developing a pain in the ass > deluxe. >=20 > Vim is probably the most arrogant and ignorant editor ever written. It > is even worse than proprietary/commercial products such as IDEs by M$, > and that's saying something. Erm. Have you met Emacs? > (I mean, if a user is pressing a certain key on his/her/its keyboard, > who could have _thought_ of the possibility that this user actually _wanted_ > to consciously press this key and have its output on the screen. > Assisted programming comes to mind; using computers as tools is one > thing, letting them do the thinking is another... :-/ ) >=20 > Of course, one could disable expanding tabs into spaces by setting up a > custom ~/.vimrc file, but this causes Vim to ignore _any_ other > directives as well, which means there is no syntax highlighting anymore, > matching brackets are not marked as such, and we are basically sitting > in front of an machine behaving like one of its colleagues in the 80s. >=20 > Some smart people came up with the idea of system-wide files such as > /etc/ssh/ssh_config, or /etc/vim/vimrc, respectively. It even contains > statements for including a _custom_ vimrc at /etc/vim/vimrc.local, which > is exactly what we want to do. >=20 > However, Vim reads its configuration from /usr/share/vim/vimrc, which is > not simply a symlink to /etc/vim/vimrc or vice versa (that would be too > easy, wouldn't it - why not spreading the same content twice across a > system to bloat up things a little bit, eh?), and jumps into a > Debian-specific configuration file afterwards. >=20 > As soon as any custom directive is placed in /etc/vim/vimrc.local and > Vim is told not to overwrite it, we are dealing with the same > less-than-default configuration mentioned above. >=20 > This leaves us with the decision of > (a) either copying the entire content of /usr/share/vim/vim81/defaults.vim > to _every_ users home directory, creating boiler plate configuration > en masse or > (b) tamper with files managed by the systems' packaging tool, which > means we are damaging the integrity of our machines (did anyone > mentioned security here?!), for nothing except a simple change to > the Python indention plugin behaviour at all. >=20 > In the authors opinion, (b) is the least unfavourable option. This patch fi= nally > "solves" the unwanted Vim behaviour on our machines, hopefully making > Michaels and my lives a little bit less harassed, since we need to puke > into one less front yard of another development team all the time. I am looking for anything to get my blood pressure down these days=E2=80=A6 Keep them coming, those fixes for the problems of my life. -Michael > Cc: Michael Tremer > Signed-off-by: Peter M=C3=BCller > --- > files/usr/share/vim/vim81/defaults.vim | 143 +++++++++++++++++++++++++ > 1 file changed, 143 insertions(+) > create mode 100644 files/usr/share/vim/vim81/defaults.vim >=20 > diff --git a/files/usr/share/vim/vim81/defaults.vim b/files/usr/share/vim/v= im81/defaults.vim > new file mode 100644 > index 0000000..100cf12 > --- /dev/null > +++ b/files/usr/share/vim/vim81/defaults.vim > @@ -0,0 +1,143 @@ > +" The default vimrc file. > +" > +" Maintainer: Bram Moolenaar > +" Last change: 2019 Feb 18 > +" > +" This is loaded if no vimrc file was found. > +" Except when Vim is run with "-u NONE" or "-C". > +" Individual settings can be reverted with ":set option&". > +" Other commands can be reverted as mentioned below. > + > +" When started as "evim", evim.vim will already have done these settings. > +if v:progname =3D~? "evim" > + finish > +endif > + > +" Bail out if something that ran earlier, e.g. a system wide vimrc, does n= ot > +" want Vim to use these default values. > +if exists('skip_defaults_vim') > + finish > +endif > + > +" Use Vim settings, rather than Vi settings (much better!). > +" This must be first, because it changes other options as a side effect. > +" Avoid side effects when it was already reset. > +if &compatible > + set nocompatible > +endif > + > +" When the +eval feature is missing, the set command above will be skipped. > +" Use a trick to reset compatible only when the +eval feature is missing. > +silent! while 0 > + set nocompatible > +silent! endwhile > + > +" Allow backspacing over everything in insert mode. > +set backspace=3Dindent,eol,start > + > +set history=3D200 " keep 200 lines of command line history > +set ruler " show the cursor position all the time > +set showcmd " display incomplete commands > +set wildmenu " display completion matches in a status line > + > +set ttimeout " time out for key codes > +set ttimeoutlen=3D100 " wait up to 100ms after Esc for special key > + > +" Show @@@ in the last line if it is truncated. > +set display=3Dtruncate > + > +" Show a few lines of context around the cursor. Note that this makes the > +" text scroll if you mouse-click near the start or end of the window. > +set scrolloff=3D5 > + > +" Do incremental searching when it's possible to timeout. > +if has('reltime') > + set incsearch > +endif > + > +" Do not recognize octal numbers for Ctrl-A and Ctrl-X, most users find it > +" confusing. > +set nrformats-=3Doctal > + > +" For Win32 GUI: remove 't' flag from 'guioptions': no tearoff menu entrie= s. > +if has('win32') > + set guioptions-=3Dt > +endif > + > +" Don't use Ex mode, use Q for formatting. > +" Revert with ":unmap Q". > +map Q gq > + > +" CTRL-U in insert mode deletes a lot. Use CTRL-G u to first break undo, > +" so that you can undo CTRL-U after inserting a line break. > +" Revert with ":iunmap ". > +inoremap u > + > +" In many terminal emulators the mouse works just fine. By enabling it you > +" can position the cursor, Visually select and scroll with the mouse. > +if has('mouse') > + set mouse=3Da > +endif > + > +" Switch syntax highlighting on when the terminal has colors or when using= the > +" GUI (which always has colors). > +if &t_Co > 2 || has("gui_running") > + " Revert with ":syntax off". > + syntax on > + > + " I like highlighting strings inside C comments. > + " Revert with ":unlet c_comment_strings". > + let c_comment_strings=3D1 > +endif > + > +" Only do this part when Vim was compiled with the +eval feature. > +if 1 > + > + " Enable file type detection. > + " Use the default filetype settings, so that mail gets 'tw' set to 72, > + " 'cindent' is on in C files, etc. > + " Also load indent files, to automatically do language-dependent indenti= ng. > + " Revert with ":filetype off". > + filetype plugin indent on > + > + " Put these in an autocmd group, so that you can revert them with: > + " ":augroup vimStartup | au! | augroup END" > + augroup vimStartup > + au! > + > + " When editing a file, always jump to the last known cursor position. > + " Don't do it when the position is invalid, when inside an event handl= er > + " (happens when dropping a file on gvim) and for a commit message (it's > + " likely a different one than last time). > + autocmd BufReadPost * > + \ if line("'\"") >=3D 1 && line("'\"") <=3D line("$") && &ft !~# 'co= mmit' > + \ | exe "normal! g`\"" > + \ | endif > + > + augroup END > + > +endif > + > +" Convenient command to see the difference between the current buffer and = the > +" file it was loaded from, thus the changes you made. > +" Only define it when not defined already. > +" Revert with: ":delcommand DiffOrig". > +if !exists(":DiffOrig") > + command DiffOrig vert new | set bt=3Dnofile | r ++edit # | 0d_ | diffthis > + \ | wincmd p | diffthis > +endif > + > +if has('langmap') && exists('+langremap') > + " Prevent that the langmap option applies to characters that result from= a > + " mapping. If set (default), this may break plugins (but it's backward > + " compatible). > + set nolangremap > +endif > + > +" Tell vim not to indent Python scripts with spaces, without > +" (a) forgetting anything else (happens if we use a custom .vimrc, but hey= !) > +" (b) overriding system-wide vimrc files such as /etc/vim/vimrc.local > +" (those are _system-wide_, so why should an application care about it= ?!) > +" (c) be too invasive when it comes to patch indention files for Python it= self > +autocmd FileType python setlocal expandtab! tabstop=3D8 shiftwidth=3D8 sof= ttabstop=3D0 > + > --=20 > 2.26.2 --===============8879477867700289045==--