From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: Core 136: Calamaris proxy reports stay empty
Date: Wed, 13 Nov 2019 16:58:20 +0000
Message-ID: <AACA7F30-0889-4601-A799-9B59779604CF@ipfire.org>
In-Reply-To: <18eb03fa-0045-4565-d889-e910c1ff4670@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2501431456548667468=="
List-Id: <development.lists.ipfire.org>

--===============2501431456548667468==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Matthias, you are not copying the list any more in most of your emails...

> On 12 Nov 2019, at 19:05, Matthias Fischer <matthias.fischer(a)ipfire.org> =
wrote:
>=20
> Hi,
>=20
> On 12.11.2019 13:53, Michael Tremer wrote:
>> Hi,
>>=20
>>> On 11 Nov 2019, at 17:17, Matthias Fischer <matthias.fischer(a)ipfire.org=
> wrote:
>>>=20
>>> On 11.11.2019 14:14, Michael Tremer wrote:
>>>> ...
>>>> Did you try changing this line as suggested?
>>>=20
>>> No, because I'm not that familiar with Perl. How would I do this?
>>>=20
>>> Line 2609ff reads:
>>>=20
>>> ...
>>> if ( defined(%tcp_content) ) {
>>=20
>> I think this line should just be:
>>=20
>> if (%tcp_content) {
>=20
> Done.
>=20
> Tested.
>=20
> Worked on both machines.
>=20
> Thanks. ;-)

Cool. Please submit a patch which we can release as a quick bug fix.

>> You might have more of those in the file, but I am sure the interpreter wi=
ll tell you when you try to run it.
>>=20
>> As far as I know this whole calamaris thing is not maintained upstream any=
 more. If this isn=E2=80=99t easily fixable we will just have to remove the f=
eature. Not sure how many users this has.
>=20
> The last version is 2.99.4.5 (V3-beta) from 2015. I took a quick look
> and there are a *lot* of changes. Hm!
>=20
> Demo-Screenshots:
> https://cord.de/files/calamaris/calamaris-3/
> https://cord.de/files/calamaris/calamaris-3-frame/

This is the HTML report. I am not sure if our version could generate those, b=
ut text is obviously easier.

> But I don't know if I can handle this - looks complicated - and I'd like
> to make a possible update dependent on the number of seriously
> interested users.

Yeah, I suppose if a drop-in replacement works we can ship it. Otherwise it i=
s not worth the effort. We have so many other things that are more important =
and more people would benefit from.

> Or I just send a patch with the above change.

Yes, please do.

>=20
> Anyone? Opinions?
>=20
> Best,
> Matthias


--===============2501431456548667468==--