Re: [PATCH 0/2] Fix Bug#12935 - status info broken on services.cgi for some addons

[Michael Tremer <michael.tremer@ipfire.org>]

[-- Attachment #1: Type: text/plain, Size: 1811 bytes --]

Hello Robin,

Sounds good. I generally agree with the solution, but I have some concerns about the implementation…

I will reply to those in the individual patch emails…

-Michael

> On 3 Oct 2022, at 16:27, Robin Roevens <robin.roevens(a)disroot.org> wrote:
> 
> Hi all
> 
> This patchset fixes Bug#12935
> (https://bugzilla.ipfire.org/show_bug.cgi?id=12935)
> 
> Summary:
> Addons where the initscript does not match the addon-name and addons with
> multiple initscripts are now listed on services.cgi since CU170.
> But addonctrl still expected addon name to be equal to
> initscript name; Hence starting/stopping/enabling/disabling of such
> addons was not possible.
> This has always been like that, but that problem was hidden as
> services.cgi also did not display those addon services.
> 
> After discussing this with Adolf on the Bug report, we concluded that we
> should adapt addonctrl to work with the new addon metadata
> Services-field instead.
> 
> I basically rewrote addonctrl to not only use the new services metadata
> but also to have better errorchecking and added the posibility to check
> if a service is currently enabled or disabled.
> As a result services.cgi no longer has to go checking the precense of
> runlevel initscripts, but can just ask addonctrl.
> I also added a warning to services.cgi if a runlevel initscript does not
> exists, to prevent the user from wondering why he can't enable a
> specific service. (Adolf pointed out some services don't install
> runlevel initscripts by default)
> 
> More details in the bugreport and in the commit-messages of the patches.
> 
> Regards
> Robin
> 
> 
> 
> -- 
> Dit bericht is gescanned op virussen en andere gevaarlijke
> inhoud door MailScanner en lijkt schoon te zijn.
>