From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH 0/2] Fix Bug#12935 - status info broken on services.cgi
 for some addons
Date: Tue, 04 Oct 2022 10:48:01 +0100
Message-ID: <AADDB1F9-BC6D-4473-AA50-26AB2D99CEB1@ipfire.org>
In-Reply-To: <20221003152720.13140-2-robin.roevens@disroot.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6383740346659616448=="
List-Id: <development.lists.ipfire.org>

--===============6383740346659616448==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello Robin,

Sounds good. I generally agree with the solution, but I have some concerns ab=
out the implementation=E2=80=A6

I will reply to those in the individual patch emails=E2=80=A6

-Michael

> On 3 Oct 2022, at 16:27, Robin Roevens <robin.roevens(a)disroot.org> wrote:
>=20
> Hi all
>=20
> This patchset fixes Bug#12935
> (https://bugzilla.ipfire.org/show_bug.cgi?id=3D12935)
>=20
> Summary:
> Addons where the initscript does not match the addon-name and addons with
> multiple initscripts are now listed on services.cgi since CU170.
> But addonctrl still expected addon name to be equal to
> initscript name; Hence starting/stopping/enabling/disabling of such
> addons was not possible.
> This has always been like that, but that problem was hidden as
> services.cgi also did not display those addon services.
>=20
> After discussing this with Adolf on the Bug report, we concluded that we
> should adapt addonctrl to work with the new addon metadata
> Services-field instead.
>=20
> I basically rewrote addonctrl to not only use the new services metadata
> but also to have better errorchecking and added the posibility to check
> if a service is currently enabled or disabled.
> As a result services.cgi no longer has to go checking the precense of
> runlevel initscripts, but can just ask addonctrl.
> I also added a warning to services.cgi if a runlevel initscript does not
> exists, to prevent the user from wondering why he can't enable a
> specific service. (Adolf pointed out some services don't install
> runlevel initscripts by default)
>=20
> More details in the bugreport and in the commit-messages of the patches.
>=20
> Regards
> Robin
>=20
>=20
>=20
> --=20
> Dit bericht is gescanned op virussen en andere gevaarlijke
> inhoud door MailScanner en lijkt schoon te zijn.
>=20


--===============6383740346659616448==--