From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Tremer To: development@lists.ipfire.org Subject: Re: Testing of rapid_commit patch Date: Fri, 29 Nov 2024 14:10:17 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4142926120507197599==" List-Id: --===============4142926120507197599== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hello, Thanks for testing this in production. Good to know this all works. > On 29 Nov 2024, at 11:21, Adolf Belka wrote: >=20 > Hi Michael, >=20 > I had previously tested your rapid_commit patch on my vm network system. Ho= wever as that network does not have a problem with the rapid_commit option it= was not the best test. >=20 > I said that i would test it out on my production system after the visit to = my family. I have now got around to that. >=20 > My new ISP, that bought out the very good technically based ISP I used to h= ave, is one of the ones that has a DHCP server that just times out if you hav= e the rapid_commit option in the dhcpcd config file. >=20 > So I updated my production IPFire to Core-Update 190 Development Build: mas= ter/1e2abd66 >=20 > After rebooting the connection was lost as the rapid_commit option is on by= default. >=20 > I then ran the setup program and unchecked the rapid commit box on the red = interface and then rebooted and the connection was running. >=20 > Another reboot still had the connection running. >=20 > So I can confirm that the patch is working . >=20 > The only thing that came to mind is when we do the update people who have r= emoved or commented out the rapid_commit option in dhcpcd.conf will lose thei= r connection. >=20 > So either >=20 > * we need to have the update check if the rapid_commit option has been comm= ented out or has been removed and then disable the rapid commit option for th= e red interface. >=20 > or >=20 > * we need to make sure that it is well communicated that anyone who has dis= abled the rapid_commit option needs to run the setup program after the upgrad= e (maybe before the reboot) to disable the option for the red interface. If we wanted to be really fancy we could check if someone has modified the co= nfiguration file and if so we can automatically set the setting in /var/ipfir= e/ethernet/settings. I am not sure how reliable this would be, but it is an o= ption. > We can discuss this at our next conf call meeting on 3rd or 4th Dec. We need to bring more things back to the list because there are currently onl= y so few people joining the call. I would also prefer to sort things out soon= er on the list if possible and keep the call as free as possible for more gen= eral discussion. -Michael >=20 > Regards, >=20 > Adolf. >=20 --===============4142926120507197599==--