From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] Core Update 165: Restart Squid during the update
Date: Mon, 21 Mar 2022 15:57:43 +0000
Message-ID: <AF99C213-5D43-49A2-A4F2-66E6C3C490EF@ipfire.org>
In-Reply-To: <f718fb49-a8c4-8d66-ce48-10997b34cf83@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5606151317178649806=="
List-Id: <development.lists.ipfire.org>

--===============5606151317178649806==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hmm, okay.

So when a service is being updated, it should be stopped before the update is=
 applied and restarted after the update is done.

We usually do that - unless it is forgotten, which happens occasionally. That=
 should however not break anything.

-Michael

> On 21 Mar 2022, at 09:01, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>=20
> Hi Peter,
>=20
> On 20/03/2022 19:32, Peter M=C3=BCller wrote:
>> Hello Michael,
>>=20
>> thanks for your reply.
>>=20
>> This is necessary because (a) we ship a new version of Squid with Core Upd=
ate 165
>> and (b) not restarting Squid afterwards caused the web proxy to stall on m=
y testing
>> machine.
> Following is for info.
>=20
> On my vm testbed I have all items running on the Services table and after t=
he CU to 165 they were all still running.
> I have never had a problem with the Web Proxy stopping running after any Co=
re Update.
>=20
> However there have been threads where people have reported occasionally tha=
t there web proxy has stopped after a core update but usually a reboot resolv=
ed that.
>=20
> Some people have reported, and I think there is still a bug open on this, w=
here the web proxy periodically stops working in normal operation and has to =
be restarted or IPFire has to be rebooted to restart it. Unfortunately those =
bug/thread originators have not usually provided logs or the logs provided ha=
ve not shown any issue.
>=20
> Regards,
> Adolf.
>> Thanks, and best regards,
>> Peter M=C3=BCller
>>=20
>>=20
>>> Why is this necessary?
>>>=20
>>>> On 20 Mar 2022, at 10:20, Peter M=C3=BCller <peter.mueller(a)ipfire.org>=
 wrote:
>>>>=20
>>>> Fixes: #12810
>>>>=20
>>>> Signed-off-by: Peter M=C3=BCller <peter.mueller(a)ipfire.org>
>>>> ---
>>>> config/rootfiles/core/165/update.sh | 1 +
>>>> 1 file changed, 1 insertion(+)
>>>>=20
>>>> diff --git a/config/rootfiles/core/165/update.sh b/config/rootfiles/core=
/165/update.sh
>>>> index ffb552c80..2c2e6a10c 100644
>>>> --- a/config/rootfiles/core/165/update.sh
>>>> +++ b/config/rootfiles/core/165/update.sh
>>>> @@ -128,6 +128,7 @@ ldconfig
>>>> # Start services
>>>> telinit u
>>>> /etc/rc.d/init.d/firewall restart
>>>> +/etc/rc.d/init.d/squid restart
>>>>=20
>>>> # Fix ownership of classification file.
>>>> chown nobody:nobody /usr/share/suricata/classification.config
>>>> --=20
>>>> 2.34.1
>=20
> --=20
> Sent from my laptop


--===============5606151317178649806==--