[PATCH] Core Update 165: Restart Squid during the update

[PATCH] Core Update 165: Restart Squid during the update

[Peter Müller]

[-- Attachment #1: Type: text/plain, Size: 621 bytes --]

Fixes: #12810

Signed-off-by: Peter Müller <peter.mueller(a)ipfire.org>
---
 config/rootfiles/core/165/update.sh | 1 +
 1 file changed, 1 insertion(+)

diff --git a/config/rootfiles/core/165/update.sh b/config/rootfiles/core/165/update.sh
index ffb552c80..2c2e6a10c 100644
--- a/config/rootfiles/core/165/update.sh
+++ b/config/rootfiles/core/165/update.sh
@@ -128,6 +128,7 @@ ldconfig
 # Start services
 telinit u
 /etc/rc.d/init.d/firewall restart
+/etc/rc.d/init.d/squid restart
 
 # Fix ownership of classification file.
 chown nobody:nobody /usr/share/suricata/classification.config
-- 
2.34.1

Re: [PATCH] Core Update 165: Restart Squid during the update

[Michael Tremer]

[-- Attachment #1: Type: text/plain, Size: 766 bytes --]

Why is this necessary?

> On 20 Mar 2022, at 10:20, Peter Müller <peter.mueller(a)ipfire.org> wrote:
> 
> Fixes: #12810
> 
> Signed-off-by: Peter Müller <peter.mueller(a)ipfire.org>
> ---
> config/rootfiles/core/165/update.sh | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/config/rootfiles/core/165/update.sh b/config/rootfiles/core/165/update.sh
> index ffb552c80..2c2e6a10c 100644
> --- a/config/rootfiles/core/165/update.sh
> +++ b/config/rootfiles/core/165/update.sh
> @@ -128,6 +128,7 @@ ldconfig
> # Start services
> telinit u
> /etc/rc.d/init.d/firewall restart
> +/etc/rc.d/init.d/squid restart
> 
> # Fix ownership of classification file.
> chown nobody:nobody /usr/share/suricata/classification.config
> -- 
> 2.34.1

Re: [PATCH] Core Update 165: Restart Squid during the update

[Peter Müller]

[-- Attachment #1: Type: text/plain, Size: 1061 bytes --]

Hello Michael,

thanks for your reply.

This is necessary because (a) we ship a new version of Squid with Core Update 165
and (b) not restarting Squid afterwards caused the web proxy to stall on my testing
machine.

Thanks, and best regards,
Peter Müller


> Why is this necessary?
> 
>> On 20 Mar 2022, at 10:20, Peter Müller <peter.mueller(a)ipfire.org> wrote:
>>
>> Fixes: #12810
>>
>> Signed-off-by: Peter Müller <peter.mueller(a)ipfire.org>
>> ---
>> config/rootfiles/core/165/update.sh | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/config/rootfiles/core/165/update.sh b/config/rootfiles/core/165/update.sh
>> index ffb552c80..2c2e6a10c 100644
>> --- a/config/rootfiles/core/165/update.sh
>> +++ b/config/rootfiles/core/165/update.sh
>> @@ -128,6 +128,7 @@ ldconfig
>> # Start services
>> telinit u
>> /etc/rc.d/init.d/firewall restart
>> +/etc/rc.d/init.d/squid restart
>>
>> # Fix ownership of classification file.
>> chown nobody:nobody /usr/share/suricata/classification.config
>> -- 
>> 2.34.1
> 

Re: [PATCH] Core Update 165: Restart Squid during the update

[Michael Tremer]

[-- Attachment #1: Type: text/plain, Size: 1387 bytes --]

Hello,

> On 20 Mar 2022, at 18:32, Peter Müller <peter.mueller(a)ipfire.org> wrote:
> 
> Hello Michael,
> 
> thanks for your reply.
> 
> This is necessary because (a) we ship a new version of Squid with Core Update 165
> and

No we don’t:

https://git.ipfire.org/?p=ipfire-2.x.git;a=tree;f=config/rootfiles/core/165/filelists;h=e076d53f7689728aa68cddaf438de39f59a5f9ac;hb=HEAD

Should we?

> (b) not restarting Squid afterwards caused the web proxy to stall on my testing
> machine.
> 
> Thanks, and best regards,
> Peter Müller
> 
> 
>> Why is this necessary?
>> 
>>> On 20 Mar 2022, at 10:20, Peter Müller <peter.mueller(a)ipfire.org> wrote:
>>> 
>>> Fixes: #12810
>>> 
>>> Signed-off-by: Peter Müller <peter.mueller(a)ipfire.org>
>>> ---
>>> config/rootfiles/core/165/update.sh | 1 +
>>> 1 file changed, 1 insertion(+)
>>> 
>>> diff --git a/config/rootfiles/core/165/update.sh b/config/rootfiles/core/165/update.sh
>>> index ffb552c80..2c2e6a10c 100644
>>> --- a/config/rootfiles/core/165/update.sh
>>> +++ b/config/rootfiles/core/165/update.sh
>>> @@ -128,6 +128,7 @@ ldconfig
>>> # Start services
>>> telinit u
>>> /etc/rc.d/init.d/firewall restart
>>> +/etc/rc.d/init.d/squid restart
>>> 
>>> # Fix ownership of classification file.
>>> chown nobody:nobody /usr/share/suricata/classification.config
>>> -- 
>>> 2.34.1
>> 

Re: [PATCH] Core Update 165: Restart Squid during the update

[Adolf Belka]

[-- Attachment #1: Type: text/plain, Size: 1947 bytes --]

Hi Peter,

On 20/03/2022 19:32, Peter Müller wrote:
> Hello Michael,
>
> thanks for your reply.
>
> This is necessary because (a) we ship a new version of Squid with Core Update 165
> and (b) not restarting Squid afterwards caused the web proxy to stall on my testing
> machine.
Following is for info.

On my vm testbed I have all items running on the Services table and 
after the CU to 165 they were all still running.
I have never had a problem with the Web Proxy stopping running after any 
Core Update.

However there have been threads where people have reported occasionally 
that there web proxy has stopped after a core update but usually a 
reboot resolved that.

Some people have reported, and I think there is still a bug open on 
this, where the web proxy periodically stops working in normal operation 
and has to be restarted or IPFire has to be rebooted to restart it. 
Unfortunately those bug/thread originators have not usually provided 
logs or the logs provided have not shown any issue.

Regards,
Adolf.
> Thanks, and best regards,
> Peter Müller
>
>
>> Why is this necessary?
>>
>>> On 20 Mar 2022, at 10:20, Peter Müller <peter.mueller(a)ipfire.org> wrote:
>>>
>>> Fixes: #12810
>>>
>>> Signed-off-by: Peter Müller <peter.mueller(a)ipfire.org>
>>> ---
>>> config/rootfiles/core/165/update.sh | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/config/rootfiles/core/165/update.sh b/config/rootfiles/core/165/update.sh
>>> index ffb552c80..2c2e6a10c 100644
>>> --- a/config/rootfiles/core/165/update.sh
>>> +++ b/config/rootfiles/core/165/update.sh
>>> @@ -128,6 +128,7 @@ ldconfig
>>> # Start services
>>> telinit u
>>> /etc/rc.d/init.d/firewall restart
>>> +/etc/rc.d/init.d/squid restart
>>>
>>> # Fix ownership of classification file.
>>> chown nobody:nobody /usr/share/suricata/classification.config
>>> -- 
>>> 2.34.1

-- 
Sent from my laptop

Re: [PATCH] Core Update 165: Restart Squid during the update

[Michael Tremer]

[-- Attachment #1: Type: text/plain, Size: 2360 bytes --]

Hmm, okay.

So when a service is being updated, it should be stopped before the update is applied and restarted after the update is done.

We usually do that - unless it is forgotten, which happens occasionally. That should however not break anything.

-Michael

> On 21 Mar 2022, at 09:01, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
> 
> Hi Peter,
> 
> On 20/03/2022 19:32, Peter Müller wrote:
>> Hello Michael,
>> 
>> thanks for your reply.
>> 
>> This is necessary because (a) we ship a new version of Squid with Core Update 165
>> and (b) not restarting Squid afterwards caused the web proxy to stall on my testing
>> machine.
> Following is for info.
> 
> On my vm testbed I have all items running on the Services table and after the CU to 165 they were all still running.
> I have never had a problem with the Web Proxy stopping running after any Core Update.
> 
> However there have been threads where people have reported occasionally that there web proxy has stopped after a core update but usually a reboot resolved that.
> 
> Some people have reported, and I think there is still a bug open on this, where the web proxy periodically stops working in normal operation and has to be restarted or IPFire has to be rebooted to restart it. Unfortunately those bug/thread originators have not usually provided logs or the logs provided have not shown any issue.
> 
> Regards,
> Adolf.
>> Thanks, and best regards,
>> Peter Müller
>> 
>> 
>>> Why is this necessary?
>>> 
>>>> On 20 Mar 2022, at 10:20, Peter Müller <peter.mueller(a)ipfire.org> wrote:
>>>> 
>>>> Fixes: #12810
>>>> 
>>>> Signed-off-by: Peter Müller <peter.mueller(a)ipfire.org>
>>>> ---
>>>> config/rootfiles/core/165/update.sh | 1 +
>>>> 1 file changed, 1 insertion(+)
>>>> 
>>>> diff --git a/config/rootfiles/core/165/update.sh b/config/rootfiles/core/165/update.sh
>>>> index ffb552c80..2c2e6a10c 100644
>>>> --- a/config/rootfiles/core/165/update.sh
>>>> +++ b/config/rootfiles/core/165/update.sh
>>>> @@ -128,6 +128,7 @@ ldconfig
>>>> # Start services
>>>> telinit u
>>>> /etc/rc.d/init.d/firewall restart
>>>> +/etc/rc.d/init.d/squid restart
>>>> 
>>>> # Fix ownership of classification file.
>>>> chown nobody:nobody /usr/share/suricata/classification.config
>>>> -- 
>>>> 2.34.1
> 
> -- 
> Sent from my laptop

Re: [PATCH] Core Update 165: Restart Squid during the update

[Peter Müller]

[-- Attachment #1: Type: text/plain, Size: 3008 bytes --]

Hello Adolf,
hello Michael,

thanks for your replies.

Indeed, Core Update 165 does not contain a new version of Squid, and indeed, there
is bug #12623 for an issue where the proxy is not being started properly during boot.
I was unfortunately never able to reproduce this, or understand from the scanty logs
supplied what went wrong here. :-/

So, whatever went wrong on my testing machine with Squid and Core Update 165, let's
drop this patch - people are urged to reboot their IPFire installations as soon as
possible anyways.

Thanks, and best regards,
Peter Müller


> Hmm, okay.
> 
> So when a service is being updated, it should be stopped before the update is applied and restarted after the update is done.
> 
> We usually do that - unless it is forgotten, which happens occasionally. That should however not break anything.
> 
> -Michael
> 
>> On 21 Mar 2022, at 09:01, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>>
>> Hi Peter,
>>
>> On 20/03/2022 19:32, Peter Müller wrote:
>>> Hello Michael,
>>>
>>> thanks for your reply.
>>>
>>> This is necessary because (a) we ship a new version of Squid with Core Update 165
>>> and (b) not restarting Squid afterwards caused the web proxy to stall on my testing
>>> machine.
>> Following is for info.
>>
>> On my vm testbed I have all items running on the Services table and after the CU to 165 they were all still running.
>> I have never had a problem with the Web Proxy stopping running after any Core Update.
>>
>> However there have been threads where people have reported occasionally that there web proxy has stopped after a core update but usually a reboot resolved that.
>>
>> Some people have reported, and I think there is still a bug open on this, where the web proxy periodically stops working in normal operation and has to be restarted or IPFire has to be rebooted to restart it. Unfortunately those bug/thread originators have not usually provided logs or the logs provided have not shown any issue.
>>
>> Regards,
>> Adolf.
>>> Thanks, and best regards,
>>> Peter Müller
>>>
>>>
>>>> Why is this necessary?
>>>>
>>>>> On 20 Mar 2022, at 10:20, Peter Müller <peter.mueller(a)ipfire.org> wrote:
>>>>>
>>>>> Fixes: #12810
>>>>>
>>>>> Signed-off-by: Peter Müller <peter.mueller(a)ipfire.org>
>>>>> ---
>>>>> config/rootfiles/core/165/update.sh | 1 +
>>>>> 1 file changed, 1 insertion(+)
>>>>>
>>>>> diff --git a/config/rootfiles/core/165/update.sh b/config/rootfiles/core/165/update.sh
>>>>> index ffb552c80..2c2e6a10c 100644
>>>>> --- a/config/rootfiles/core/165/update.sh
>>>>> +++ b/config/rootfiles/core/165/update.sh
>>>>> @@ -128,6 +128,7 @@ ldconfig
>>>>> # Start services
>>>>> telinit u
>>>>> /etc/rc.d/init.d/firewall restart
>>>>> +/etc/rc.d/init.d/squid restart
>>>>>
>>>>> # Fix ownership of classification file.
>>>>> chown nobody:nobody /usr/share/suricata/classification.config
>>>>> -- 
>>>>> 2.34.1
>>
>> -- 
>> Sent from my laptop
> 

Re: [PATCH] Core Update 165: Restart Squid during the update

[Michael Tremer]

[-- Attachment #1: Type: text/plain, Size: 3351 bytes --]

Hello,

> On 23 Mar 2022, at 09:34, Peter Müller <peter.mueller(a)ipfire.org> wrote:
> 
> Hello Adolf,
> hello Michael,
> 
> thanks for your replies.
> 
> Indeed, Core Update 165 does not contain a new version of Squid, and indeed, there
> is bug #12623 for an issue where the proxy is not being started properly during boot.
> I was unfortunately never able to reproduce this, or understand from the scanty logs
> supplied what went wrong here. :-/

Arne confirmed to me yesterday that he has seen the proxy not coming up properly on a test system. Maybe he can help finding this?

> So, whatever went wrong on my testing machine with Squid and Core Update 165, let's
> drop this patch - people are urged to reboot their IPFire installations as soon as
> possible anyways.
> 
> Thanks, and best regards,
> Peter Müller
> 
> 
>> Hmm, okay.
>> 
>> So when a service is being updated, it should be stopped before the update is applied and restarted after the update is done.
>> 
>> We usually do that - unless it is forgotten, which happens occasionally. That should however not break anything.
>> 
>> -Michael
>> 
>>> On 21 Mar 2022, at 09:01, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>>> 
>>> Hi Peter,
>>> 
>>> On 20/03/2022 19:32, Peter Müller wrote:
>>>> Hello Michael,
>>>> 
>>>> thanks for your reply.
>>>> 
>>>> This is necessary because (a) we ship a new version of Squid with Core Update 165
>>>> and (b) not restarting Squid afterwards caused the web proxy to stall on my testing
>>>> machine.
>>> Following is for info.
>>> 
>>> On my vm testbed I have all items running on the Services table and after the CU to 165 they were all still running.
>>> I have never had a problem with the Web Proxy stopping running after any Core Update.
>>> 
>>> However there have been threads where people have reported occasionally that there web proxy has stopped after a core update but usually a reboot resolved that.
>>> 
>>> Some people have reported, and I think there is still a bug open on this, where the web proxy periodically stops working in normal operation and has to be restarted or IPFire has to be rebooted to restart it. Unfortunately those bug/thread originators have not usually provided logs or the logs provided have not shown any issue.
>>> 
>>> Regards,
>>> Adolf.
>>>> Thanks, and best regards,
>>>> Peter Müller
>>>> 
>>>> 
>>>>> Why is this necessary?
>>>>> 
>>>>>> On 20 Mar 2022, at 10:20, Peter Müller <peter.mueller(a)ipfire.org> wrote:
>>>>>> 
>>>>>> Fixes: #12810
>>>>>> 
>>>>>> Signed-off-by: Peter Müller <peter.mueller(a)ipfire.org>
>>>>>> ---
>>>>>> config/rootfiles/core/165/update.sh | 1 +
>>>>>> 1 file changed, 1 insertion(+)
>>>>>> 
>>>>>> diff --git a/config/rootfiles/core/165/update.sh b/config/rootfiles/core/165/update.sh
>>>>>> index ffb552c80..2c2e6a10c 100644
>>>>>> --- a/config/rootfiles/core/165/update.sh
>>>>>> +++ b/config/rootfiles/core/165/update.sh
>>>>>> @@ -128,6 +128,7 @@ ldconfig
>>>>>> # Start services
>>>>>> telinit u
>>>>>> /etc/rc.d/init.d/firewall restart
>>>>>> +/etc/rc.d/init.d/squid restart
>>>>>> 
>>>>>> # Fix ownership of classification file.
>>>>>> chown nobody:nobody /usr/share/suricata/classification.config
>>>>>> -- 
>>>>>> 2.34.1
>>> 
>>> -- 
>>> Sent from my laptop
>> 

Re: [PATCH] Core Update 165: Restart Squid during the update

[Peter Müller]

[-- Attachment #1: Type: text/plain, Size: 3682 bytes --]

Hello Michael,
hello Arne,

> Hello,
> 
>> On 23 Mar 2022, at 09:34, Peter Müller <peter.mueller(a)ipfire.org> wrote:
>>
>> Hello Adolf,
>> hello Michael,
>>
>> thanks for your replies.
>>
>> Indeed, Core Update 165 does not contain a new version of Squid, and indeed, there
>> is bug #12623 for an issue where the proxy is not being started properly during boot.
>> I was unfortunately never able to reproduce this, or understand from the scanty logs
>> supplied what went wrong here. :-/
> 
> Arne confirmed to me yesterday that he has seen the proxy not coming up properly on a test system. Maybe he can help finding this?

that would be great. On roughly a dozen of IPFire installations, all using the web proxy,
I was never able to spot this.

Therefore, I would be most interested in Arne's findings.

Thanks, and best regards,
Peter Müller

> 
>> So, whatever went wrong on my testing machine with Squid and Core Update 165, let's
>> drop this patch - people are urged to reboot their IPFire installations as soon as
>> possible anyways.
>>
>> Thanks, and best regards,
>> Peter Müller
>>
>>
>>> Hmm, okay.
>>>
>>> So when a service is being updated, it should be stopped before the update is applied and restarted after the update is done.
>>>
>>> We usually do that - unless it is forgotten, which happens occasionally. That should however not break anything.
>>>
>>> -Michael
>>>
>>>> On 21 Mar 2022, at 09:01, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>>>>
>>>> Hi Peter,
>>>>
>>>> On 20/03/2022 19:32, Peter Müller wrote:
>>>>> Hello Michael,
>>>>>
>>>>> thanks for your reply.
>>>>>
>>>>> This is necessary because (a) we ship a new version of Squid with Core Update 165
>>>>> and (b) not restarting Squid afterwards caused the web proxy to stall on my testing
>>>>> machine.
>>>> Following is for info.
>>>>
>>>> On my vm testbed I have all items running on the Services table and after the CU to 165 they were all still running.
>>>> I have never had a problem with the Web Proxy stopping running after any Core Update.
>>>>
>>>> However there have been threads where people have reported occasionally that there web proxy has stopped after a core update but usually a reboot resolved that.
>>>>
>>>> Some people have reported, and I think there is still a bug open on this, where the web proxy periodically stops working in normal operation and has to be restarted or IPFire has to be rebooted to restart it. Unfortunately those bug/thread originators have not usually provided logs or the logs provided have not shown any issue.
>>>>
>>>> Regards,
>>>> Adolf.
>>>>> Thanks, and best regards,
>>>>> Peter Müller
>>>>>
>>>>>
>>>>>> Why is this necessary?
>>>>>>
>>>>>>> On 20 Mar 2022, at 10:20, Peter Müller <peter.mueller(a)ipfire.org> wrote:
>>>>>>>
>>>>>>> Fixes: #12810
>>>>>>>
>>>>>>> Signed-off-by: Peter Müller <peter.mueller(a)ipfire.org>
>>>>>>> ---
>>>>>>> config/rootfiles/core/165/update.sh | 1 +
>>>>>>> 1 file changed, 1 insertion(+)
>>>>>>>
>>>>>>> diff --git a/config/rootfiles/core/165/update.sh b/config/rootfiles/core/165/update.sh
>>>>>>> index ffb552c80..2c2e6a10c 100644
>>>>>>> --- a/config/rootfiles/core/165/update.sh
>>>>>>> +++ b/config/rootfiles/core/165/update.sh
>>>>>>> @@ -128,6 +128,7 @@ ldconfig
>>>>>>> # Start services
>>>>>>> telinit u
>>>>>>> /etc/rc.d/init.d/firewall restart
>>>>>>> +/etc/rc.d/init.d/squid restart
>>>>>>>
>>>>>>> # Fix ownership of classification file.
>>>>>>> chown nobody:nobody /usr/share/suricata/classification.config
>>>>>>> -- 
>>>>>>> 2.34.1
>>>>
>>>> -- 
>>>> Sent from my laptop
>>>
>