From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] ovpnmain.cgi: Remove unnecessary check/error message
Date: Tue, 07 Sep 2021 16:58:57 +0100 [thread overview]
Message-ID: <B0541034-CFA7-4485-B106-745E902C6C91@ipfire.org> (raw)
In-Reply-To: <20210907155309.1896-1-hofmann@leo-andres.de>
[-- Attachment #1: Type: text/plain, Size: 1034 bytes --]
You are a star :)
Reviewed-by: Michael Tremer <michael.tremer(a)ipfire.org>
-Michael
> On 7 Sep 2021, at 16:53, Leo-Andres Hofmann <hofmann(a)leo-andres.de> wrote:
>
> This parameter can either be "host" or "net", but the existing check
> only allows "net" entries. Since other entries are also valid but
> don't require further action, this patch removes the error message.
>
> Fixes: #12686
>
> Signed-off-by: Leo-Andres Hofmann <hofmann(a)leo-andres.de>
> ---
> html/cgi-bin/ovpnmain.cgi | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/html/cgi-bin/ovpnmain.cgi b/html/cgi-bin/ovpnmain.cgi
> index 3cd2f9381..2ebf384ed 100644
> --- a/html/cgi-bin/ovpnmain.cgi
> +++ b/html/cgi-bin/ovpnmain.cgi
> @@ -2183,9 +2183,6 @@ END
> &General::system("/usr/local/bin/openvpnctrl", "-kn2n", "$confighash{$cgiparams{'KEY'}}[1]");
> &writecollectdconf();
> }
> -
> - } else {
> - $errormessage = $Lang::tr{'invalid key'};
> }
> }
> }
> --
> 2.27.0.windows.1
>
prev parent reply other threads:[~2021-09-07 15:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-07 15:53 Leo-Andres Hofmann
2021-09-07 15:58 ` Michael Tremer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B0541034-CFA7-4485-B106-745E902C6C91@ipfire.org \
--to=michael.tremer@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox