From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] ovpnmain.cgi: Remove unnecessary check/error message
Date: Tue, 07 Sep 2021 16:58:57 +0100
Message-ID: <B0541034-CFA7-4485-B106-745E902C6C91@ipfire.org>
In-Reply-To: <20210907155309.1896-1-hofmann@leo-andres.de>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8770975699412576811=="
List-Id: <development.lists.ipfire.org>

--===============8770975699412576811==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

You are a star :)

Reviewed-by: Michael Tremer <michael.tremer(a)ipfire.org>

-Michael

> On 7 Sep 2021, at 16:53, Leo-Andres Hofmann <hofmann(a)leo-andres.de> wrote:
>=20
> This parameter can either be "host" or "net", but the existing check
> only allows "net" entries. Since other entries are also valid but
> don't require further action, this patch removes the error message.
>=20
> Fixes: #12686
>=20
> Signed-off-by: Leo-Andres Hofmann <hofmann(a)leo-andres.de>
> ---
> html/cgi-bin/ovpnmain.cgi | 3 ---
> 1 file changed, 3 deletions(-)
>=20
> diff --git a/html/cgi-bin/ovpnmain.cgi b/html/cgi-bin/ovpnmain.cgi
> index 3cd2f9381..2ebf384ed 100644
> --- a/html/cgi-bin/ovpnmain.cgi
> +++ b/html/cgi-bin/ovpnmain.cgi
> @@ -2183,9 +2183,6 @@ END
> 					&General::system("/usr/local/bin/openvpnctrl", "-kn2n", "$confighash{$=
cgiparams{'KEY'}}[1]");
> 					&writecollectdconf();
> 				}
> -=20
> -			} else {
> -				$errormessage =3D $Lang::tr{'invalid key'};
> 			}
> 		}
>   }
> --=20
> 2.27.0.windows.1
>=20


--===============8770975699412576811==--