Re: [PATCH] vnstat 2.6: Fix for lfs

[Michael Tremer <michael.tremer@ipfire.org>]

[-- Attachment #1: Type: text/plain, Size: 2035 bytes --]



> On 11 Apr 2020, at 19:17, Matthias Fischer <matthias.fischer(a)ipfire.org> wrote:
> 
> Hi,
> 
> On 11.04.2020 20:03, Michael Tremer wrote:
>> Hi,
>> 
>>> On 11 Apr 2020, at 17:39, Matthias Fischer <matthias.fischer(a)ipfire.org> wrote:
>>> 
>>> Hi.
>>> 
>>> On 11.04.2020 17:28, Michael Tremer wrote:
>>>> Hello,
>>>> 
>>>> Thanks for the patch, but this only solves one of my concerns.
>>> 
>>> You mean the exit status for the 'stop'-section?
>> 
>> No, everywhere.
> 
> -v please.

LOL. Good one :)

So, you are launching vnstatd by calling loadproc.

That function will start the process and print “OK” or “ERROR” in a colour on the console.

Calling evaluate_retval (which should be called in loadproc, too) will then print OK again.

Did it not do that when you tested it?

-Michael

> 
> 'evaluate_retval' is now four times in, status output has been added.
> 
> Anything else?
> 
>> 
>>> 
>>>> What about printing the colourful exit status more than once?
>>> 
>>> Done... ;-)
>>> 
>>>> Best,
>>>> -Michael
>>>> 
>>>>> On 11 Apr 2020, at 15:38, Matthias Fischer <matthias.fischer(a)ipfire.org> wrote:
>>>>> 
>>>>> Removed 'sleep 2'
>>>>> 
>>>>> Signed-off-by: Matthias Fischer <matthias.fischer(a)ipfire.org>
>>>>> ---
>>>>> src/initscripts/system/vnstat | 2 --
>>>>> 1 file changed, 2 deletions(-)
>>>>> 
>>>>> diff --git a/src/initscripts/system/vnstat b/src/initscripts/system/vnstat
>>>>> index bcc19c3ab..a21905d75 100755
>>>>> --- a/src/initscripts/system/vnstat
>>>>> +++ b/src/initscripts/system/vnstat
>>>>> @@ -20,14 +20,12 @@ case "$1" in
>>>>> 
>>>>> 		boot_mesg "Starting vnstatd..."
>>>>> 		loadproc /usr/sbin/vnstatd -d --alwaysadd
>>>>> -		sleep 2
>>>>> 		evaluate_retval
>>>>> 		;;
>>>>> 
>>>>> 	stop)
>>>>> 		boot_mesg "Stopping vnstatd..."
>>>>> 		killproc /usr/sbin/vnstatd
>>>>> -		sleep 2
>>>>> 		evaluate_retval
>>>>> 
>>>>> 		umount_ramdisk "${VNSTATLOG}"
>>>>> -- 
>>>>> 2.18.0
>>>>> 
>>>> 
>>> 
>> 
>