From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] vnstat 2.6: Fix for lfs
Date: Sat, 11 Apr 2020 19:21:42 +0100
Message-ID: <B0F04922-D6F5-4778-B652-CF8205B85FD6@ipfire.org>
In-Reply-To: <c422d937-9159-5914-9a4e-726c5bd60804@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1732695220071935864=="
List-Id: <development.lists.ipfire.org>

--===============1732695220071935864==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable



> On 11 Apr 2020, at 19:17, Matthias Fischer <matthias.fischer(a)ipfire.org> =
wrote:
>=20
> Hi,
>=20
> On 11.04.2020 20:03, Michael Tremer wrote:
>> Hi,
>>=20
>>> On 11 Apr 2020, at 17:39, Matthias Fischer <matthias.fischer(a)ipfire.org=
> wrote:
>>>=20
>>> Hi.
>>>=20
>>> On 11.04.2020 17:28, Michael Tremer wrote:
>>>> Hello,
>>>>=20
>>>> Thanks for the patch, but this only solves one of my concerns.
>>>=20
>>> You mean the exit status for the 'stop'-section?
>>=20
>> No, everywhere.
>=20
> -v please.

LOL. Good one :)

So, you are launching vnstatd by calling loadproc.

That function will start the process and print =E2=80=9COK=E2=80=9D or =E2=80=
=9CERROR=E2=80=9D in a colour on the console.

Calling evaluate_retval (which should be called in loadproc, too) will then p=
rint OK again.

Did it not do that when you tested it?

-Michael

>=20
> 'evaluate_retval' is now four times in, status output has been added.
>=20
> Anything else?
>=20
>>=20
>>>=20
>>>> What about printing the colourful exit status more than once?
>>>=20
>>> Done... ;-)
>>>=20
>>>> Best,
>>>> -Michael
>>>>=20
>>>>> On 11 Apr 2020, at 15:38, Matthias Fischer <matthias.fischer(a)ipfire.o=
rg> wrote:
>>>>>=20
>>>>> Removed 'sleep 2'
>>>>>=20
>>>>> Signed-off-by: Matthias Fischer <matthias.fischer(a)ipfire.org>
>>>>> ---
>>>>> src/initscripts/system/vnstat | 2 --
>>>>> 1 file changed, 2 deletions(-)
>>>>>=20
>>>>> diff --git a/src/initscripts/system/vnstat b/src/initscripts/system/vns=
tat
>>>>> index bcc19c3ab..a21905d75 100755
>>>>> --- a/src/initscripts/system/vnstat
>>>>> +++ b/src/initscripts/system/vnstat
>>>>> @@ -20,14 +20,12 @@ case "$1" in
>>>>>=20
>>>>> 		boot_mesg "Starting vnstatd..."
>>>>> 		loadproc /usr/sbin/vnstatd -d --alwaysadd
>>>>> -		sleep 2
>>>>> 		evaluate_retval
>>>>> 		;;
>>>>>=20
>>>>> 	stop)
>>>>> 		boot_mesg "Stopping vnstatd..."
>>>>> 		killproc /usr/sbin/vnstatd
>>>>> -		sleep 2
>>>>> 		evaluate_retval
>>>>>=20
>>>>> 		umount_ramdisk "${VNSTATLOG}"
>>>>> --=20
>>>>> 2.18.0
>>>>>=20
>>>>=20
>>>=20
>>=20
>=20


--===============1732695220071935864==--