From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Tremer To: development@lists.ipfire.org Subject: Re: [FEATURE] Zone configuration Date: Fri, 17 May 2019 22:38:24 +0100 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8657931618248408086==" List-Id: --===============8657931618248408086== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hey guys, Great work here :) I talked to Florian in private and said that I do not think it is a good idea= to swap the columns. I have no idea what I was thinking there. Of course it = makes sense. Must have switched my brain off before talking. I am in favour of this. I just have no idea if we can have this land in Core = Update 132 since we have some urgent security stuff in there and Arne wants t= o close it as soon as possible. Florian, what is your availability and do you think you can have this done by= Monday? No pressure, I do not think it is the end of the world if we ship it= like this. Alternatively we can deactivate the menu option so that users won= =E2=80=99t see it yet. Whatever you prefer. Best, -Michael > On 14 May 2019, at 22:04, Alexander Koch = wrote: >=20 > Hi Florian, >=20 > I vote for switching columns/rows. I think a maximum of four columns (or ar= e you planning to extend the zones too?) results in a better usability than a= n additional horizontal scrollbar. And the other GUI-pages grow vertically to= o. The Network Settings could be placed in the first row(s), just like a NIC.= What about alternating the background colour (light grey/dark gray) of the r= ows like on the firewall rules and the logs pages? >=20 > Different topic, but related to yours: I'm currently running multiple SSIDs= with hostapd on my IPFire machines (one for green and one for blue) by creat= ing the bridges in an initscript and editing the hostapd-config manually. Bas= ed on your new Zoneconfig-Feature (it creates the bridges required by hostapd= and makes things a lot easier) it is possible to write a patch for the wlana= p.cgi to implement this properly. Are you or anybody else already working on = this? I would join in or start it ... >=20 > Regards, Alex >=20 > From: Florian B=C3=BChrle [mailto:erdlof(a)protonmail.com] > Sent: Tuesday, 14 May 2019, 07:23 CEST > To: ipfire(a)starkstromkonsument.de > Cc: development(a)lists.ipfire.org > Subject: [FEATURE] Zone configuration >=20 >> Hello Alexander, >>=20 >> thank you for your feedback! >>=20 >> 1. Yes, applying these settings requires a restart. I also think we should= inform users of that in the GUI. >> 2. This is actually a major issue. I thought of two possible fixes: either= the columns/rows get switched so the table grows vertically; or we introduce= a scrollbar. Personally I think a scrollbar would be a better idea as I plan= to also introduce network settings to the zoneconf interface so the site cou= ld get rather large if a user has many NICs on their machine. Also I think th= e height of the site should be consistent. >> What do you think? >>=20 >> Regards >> Florian >>=20 >>=20 >>=20 >> -------- Original-Nachricht -------- >> An 13. Mai 2019, 23:58, Alexander Koch schrieb: >>=20 >> Hello Florian, >>=20 >> thank you for providing this new feature. I think it is a big enhancement = to the user experience to bring this to the GUI. I tested the current nightly= build (next/9d959ac1) and found two little issues: >>=20 >> =E2=80=A2 The changes will not be applied until I reboot the machine. Is = this the expected behaviour? If yes: I think there should be a hint on the pa= ge to inform the user about it and the file /var/run/need_reboot should be cr= eated to activate the corresponding banner "An update requires a restart!" in= the GUI. Maybe the translations should be updated too. E.g. "An update or co= nfig change requires a reboot! >> =E2=80=A2 If I use the GUI-Theme "ipfire-legacy" and the system has more = than three NICSs, the GUI-Content will overlap the sidemenu. I attached a scr= eenshot with this. >> Regards, Alex >>=20 >>=20 >> From: Florian B=C3=BChrle [mailto:erdlof(a)protonmail.com] >> Sent: Saturday, 11 May 2019, 15:57 CEST >> To: development(a)lists.ipfire.org >> Subject: [FEATURE] Zone configuration >>=20 >>> Hey all, >>> I made a new web interface that allows users to assign network interfaces= to zones. Check out the wiki article https://wiki.ipfire.org/configuration/n= etwork/zoneconf. >>>=20 >>> This feature is already part of the "next" branch of the IPFire 2.x main = tree. Please review it and check for bugs :) >>>=20 >>> Regards >>> Flo --===============8657931618248408086==--