From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH 1/4] initscripts: Add generic function to get the filesystem type of a volume
Date: Wed, 27 Mar 2024 10:15:32 +0000 [thread overview]
Message-ID: <B701088B-90FC-4E2E-AAF8-E25B83AF9E38@ipfire.org> (raw)
In-Reply-To: <20240327051520.8231-1-stefan.schantl@ipfire.org>
[-- Attachment #1: Type: text/plain, Size: 838 bytes --]
Hello Stefan,
> On 27 Mar 2024, at 05:15, Stefan Schantl <stefan.schantl(a)ipfire.org> wrote:
>
> Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
> ---
> src/initscripts/system/functions | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/src/initscripts/system/functions b/src/initscripts/system/functions
> index 5a26aef45..0fa825000 100644
> --- a/src/initscripts/system/functions
> +++ b/src/initscripts/system/functions
> @@ -883,3 +883,11 @@ running_on_oci() {
> # We are not running on OCI
> return 1
> }
> +
> +volume_fs_type() {
> + if [ ! -d "${1}" ]; then
> + return
> + fi
> +
> + echo "$(stat -f --format="%T" ${1})"
You don’t need to run a sub shell for this and echo the result. It would be enough to just call stat with its arguments.
> +}
> --
> 2.39.2
>
next prev parent reply other threads:[~2024-03-27 10:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-24 12:39 [PATCH 1/2] inotify-tools: New package Stefan Schantl
2024-03-24 12:39 ` [PATCH 2/2] grub-btrfs: " Stefan Schantl
2024-03-25 10:38 ` Michael Tremer
2024-03-27 5:15 ` [PATCH 1/4] initscripts: Add generic function to get the filesystem type of a volume Stefan Schantl
2024-03-27 5:15 ` [PATCH 2/4] grub-btrfsd: Use generic volume_fs_type function for FS detection Stefan Schantl
2024-03-27 5:15 ` [PATCH 3/4] grub-btrfsd: Adjust displayed starting message Stefan Schantl
2024-03-27 5:15 ` [PATCH 4/4] grub-btrfsd: Drop redundant used PIDFILE mechanism Stefan Schantl
2024-03-27 10:15 ` Michael Tremer
2024-03-27 19:42 ` Stefan Schantl
2024-03-28 10:32 ` Michael Tremer
2024-03-27 10:15 ` Michael Tremer [this message]
2024-03-27 19:43 ` [PATCH 1/4] initscripts: Add generic function to get the filesystem type of a volume Stefan Schantl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B701088B-90FC-4E2E-AAF8-E25B83AF9E38@ipfire.org \
--to=michael.tremer@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox