From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Tremer To: development@lists.ipfire.org Subject: Re: [PATCH 1/2] Tor: fix permissions of /var/ipfire/tor/torrc after installation Date: Wed, 13 Nov 2019 10:04:16 +0000 Message-ID: In-Reply-To: <0b93a03e-dd4f-3993-1118-d9283fd44d05@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6049099931461125059==" List-Id: --===============6049099931461125059== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Peter, Stephan contacted me yesterday and said he just pressed a wrong button and se= nt his patch and the previous commit together as one patchset. So just ignore this. Best, -Michael > On 12 Nov 2019, at 21:32, Peter M=C3=BCller wr= ote: >=20 > Hello Stephan, >=20 > unfortunately, I do not understand this mail. Isn't that the Tor > permission patch of mine sent in a while ago? What is the relationship > to wio? >=20 > Besides: Your other patches miss the "Signed-off-by"-Tag. Just > thought you might want to know... >=20 > Thanks, and best regards, > Peter M=C3=BCller >=20 >=20 >> From: "peter.mueller(a)ipfire.org" >>=20 >> Fixes #12220 >>=20 >> Reported-by: Michael Tremer >> Signed-off-by: Peter M=C3=BCller >> Signed-off-by: Arne Fitzenreiter >> --- >> lfs/tor | 2 +- >> src/paks/tor/install.sh | 8 ++++---- >> 2 files changed, 5 insertions(+), 5 deletions(-) >>=20 >> diff --git a/lfs/tor b/lfs/tor >> index ea07f6ce2..178f84be9 100644 >> --- a/lfs/tor >> +++ b/lfs/tor >> @@ -32,7 +32,7 @@ DL_FROM =3D $(URL_IPFIRE) >> DIR_APP =3D $(DIR_SRC)/$(THISAPP) >> TARGET =3D $(DIR_INFO)/$(THISAPP) >> PROG =3D tor >> -PAK_VER =3D 43 >> +PAK_VER =3D 44 >>=20 >> DEPS =3D "libseccomp" >>=20 >> diff --git a/src/paks/tor/install.sh b/src/paks/tor/install.sh >> index 4d0353155..369b65f71 100644 >> --- a/src/paks/tor/install.sh >> +++ b/src/paks/tor/install.sh >> @@ -36,10 +36,10 @@ extract_files >> restore_backup ${NAME} >>=20 >> # Adjust some folder permission for new UID/GID >> -chown -R tor:tor /var/lib/tor /var/ipfire/tor >> +chown -R tor:tor /var/lib/tor >> +chown -R tor:nobody /var/ipfire/tor >>=20 >> -# Tor settings file needs to be writeable by nobody group for WebUI >> -chown tor:nobody /var/ipfire/tor/settings >> -chmod 664 /var/ipfire/tor/settings >> +# Tor settings files needs to be writeable by nobody group for WebUI >> +chmod 664 /var/ipfire/tor/{settings,torrc} >>=20 >> start_service --background ${NAME} >>=20 --===============6049099931461125059==--