From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.haj.ipfire.org (localhost [127.0.0.1]) by mail02.haj.ipfire.org (Postfix) with ESMTP id 4ZFNVr2pq4z377q for ; Sat, 15 Mar 2025 14:13:08 +0000 (UTC) Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) client-signature RSA-PSS (4096 bits)) (Client CN "mail01.haj.ipfire.org", Issuer "R10" (verified OK)) by mail02.haj.ipfire.org (Postfix) with ESMTPS id 4ZFNVm5HL6z32vy for ; Sat, 15 Mar 2025 14:13:04 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail01.ipfire.org (Postfix) with ESMTPSA id 4ZFNVm0V7Cz1s1; Sat, 15 Mar 2025 14:13:03 +0000 (UTC) DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003ed25519; t=1742047984; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0HQIezByxKBwNQx4TG3+LXBRqHZ5Gv01KIHpR5ilQO4=; b=8IhC1I7SdZ1yzgzGwgcecmiwqVWSEGwtXaclMobVqBffVXqZnChg2uiYT+u2qnfK9ZtWqu 6Tkw7P2UdZ3j4VAw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003rsa; t=1742047984; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0HQIezByxKBwNQx4TG3+LXBRqHZ5Gv01KIHpR5ilQO4=; b=sUk5m/clsFXaHiWAJZvXzA9LomYE6SxYEXdLk+31BZJAKJTI7QflB6Vxe7PM6gUc03TkLi 1SgddYwlxtkN7kYoSWS3mLeIURSNwy81d7rPg7TQTLU91nHggXbr28qIfm26ahBKM+wQdE GS4jD32vZKvK/4DNEt6zZy8htLc9iF7J2vOtpM8JtwqFJAPT6+amD18sdbx/f9+D9d+mxx 3RKsBsw+5Bbw5i/QEvvQFKmdgMTFNrU3Z8riHcgJf0gii7ooJYq8k6GA3xsgTe14ZCseBt aMmEf1sDL2fqlmHZ7GaPvbLxatWv1lCdJoGqYcTAlhr7i1QMlPNZeLXFq9Nhtg== Content-Type: text/plain; charset=us-ascii Precedence: list List-Id: List-Subscribe: , List-Unsubscribe: , List-Post: List-Help: Sender: Mail-Followup-To: Mime-Version: 1.0 Subject: Re: collectd openvpn errors if openvpn not used From: Michael Tremer In-Reply-To: Date: Sat, 15 Mar 2025 14:13:03 +0000 Cc: "IPFire: Development-List" Content-Transfer-Encoding: quoted-printable Message-Id: References: To: Adolf Belka Hello Adolf, I think we should comment out the OpenVPN module in collectd.conf. We = are doing this for some other modules already: = https://git.ipfire.org/?p=3Dipfire-2.x.git;a=3Dblob;f=3Dsrc/initscripts/sy= stem/collectd;h=3D263511fc7c1fd5bf5450f11558ac6bce0e167828;hb=3DHEAD This just means that we also want to restart collectd after OpenVPN was = enabled/disabled so that it is always in sync. -Michael > On 15 Mar 2025, at 13:49, Adolf Belka wrote: >=20 > Hi Michael and all, >=20 > Error messages from collectd have been reported in the forum with Core = Update 192 (so the 15.12.0 update). >=20 > The messages were:- >=20 > 07:19:24 collectd[17386]: read-function of plugin = `openvpn/ovpnserver.log' failed. Will suspend it for 30720.000 seconds. > 07:19:24 collectd[17386]: openvpn plugin: failed to get data from: = /var/run/ovpnserver.log > 03:03:24 collectd[17386]: read-function of plugin = `openvpn/ovpnserver.log' failed. Will suspend it for 15360.000 seconds. > 03:03:24 collectd[17386]: openvpn plugin: failed to get data from: = /var/run/ovpnserver.log > 00:55:24 collectd[17386]: read-function of plugin = `openvpn/ovpnserver.log' failed. Will suspend it for 7680.000 seconds. > 00:55:24 collectd[17386]: openvpn plugin: failed to get data from: = /var/run/ovpnserver.log=20 >=20 > It appears that the users that are not using openvpn are the ones = seeing these messages. They apparently do have the = /var/run/ovpnserver.log file but it is empty. >=20 > Looking back through the IPFIre git repo I saw that some of the 22 odd = patches that had been applied to collectd-4.10.9 were related to openvpn = and some of them to silencing openvpn errors. >=20 > I identified 7 patches related to openvpn, all patching the = /src/openvpn.c file in the collectd source tarball. >=20 > I compared all these patches with the collectd-5.12.0 source tarball. >=20 > One of the files had its contents now included in the source tarball. = This was the one related to changing the openvpn plugin from a COUNTER = to a DERIVE approach. >=20 > The other 6 patches I could not find virtually any match as the = openvpn.c code is significantly different enough that finding the = section of code where the changes should be applied was impossible. In = many cases the variables being changes are no longer present, or if = present are used in very different commands now. >=20 > Any thoughts on how to fix this. Do we need to basically completely = re-write the old patches to be able to work in the new code or is there = some way to be able to detect that openvpn is not running and therefore = comment out the include openvpn plugin command in the collectd.conf file = in the same way as we do with the thermal plugin. >=20 > The issue I see with this is that the thermal line is commented out = via the collectd initscript, presumably because if this is not capable = at boot it won't change while the system is running. >=20 > However with openvpn the user could enable openvpn to start and then = we would need to make the collectd daemon restart so that the initscript = could uncomment the include openvpn plugin line. >=20 > Editing the openvpn.c code is beyond my capabilities but the second = option to uncomment the openvpn plugin line if openvpn is started might = be in my capabilities. >=20 > Any thoughts or other suggestions on this issue. >=20 > Regards, > Adolf. >=20 >=20 >=20 > --=20 > Sent from my laptop