From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Tremer To: development@lists.ipfire.org Subject: Re: [PATCH] BUG12403: Change group permission of dma.conf Date: Wed, 13 May 2020 09:29:42 +0100 Message-ID: In-Reply-To: <20200513045741.21469-1-alexander.marx@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0671393330700948071==" List-Id: --===============0671393330700948071== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi, This solution looks a lot better to me. Do we have to restore permissions when a backup is restored, too? -Michael Reviewed-by: Michael Tremer > On 13 May 2020, at 05:57, Alexander Marx wrot= e: >=20 > Because other services that run as other users than nobody should be > able to send mails, this patch changes the permissions >=20 > from > nobody.root >=20 > to > nobody.mail >=20 > When another user wants to send mails via DMA, the user has to be put into = the group "mail". >=20 > FIXES: #12403 >=20 > Arne: Please take care of update script, so these changes affect normal upd= ate procedure. > --- > lfs/dma | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) >=20 > diff --git a/lfs/dma b/lfs/dma > index 6b5d9bfbf..7f0c2cc0e 100644 > --- a/lfs/dma > +++ b/lfs/dma > @@ -79,8 +79,7 @@ $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects)) > cd $(DIR_APP) && make install mailq-link install-spool-dirs install-etc > install -v -m 755 $(DIR_SRC)/config/dma/dma-cleanup-spool /usr/sbin > chown -R nobody.nobody /var/ipfire/dma > - chown nobody.root /var/ipfire/dma/auth.conf > - chmod 644 /var/ipfire/dma/auth.conf > + chown nobody.mail /var/ipfire/dma/auth.conf > ln -svf dma /usr/sbin/sendmail.dma > /usr/sbin/alternatives --install /usr/sbin/sendmail sendmail /usr/sbin/sen= dmail.dma 20 > @rm -rf $(DIR_APP) > --=20 > 2.17.1 >=20 --===============0671393330700948071==--