Re: [PATCH] optionsfw.cgi: Centered 'Save...' buttons - added missing lang strings

[Michael Tremer <michael.tremer@ipfire.org>]

[-- Attachment #1: Type: text/plain, Size: 1908 bytes --]

Hi,

> On 28 Dec 2020, at 14:48, Matthias Fischer <matthias.fischer(a)ipfire.org> wrote:
> 
> I had these already used in my previous DNS/NTP-patch, that's why I missed
> them.

That’s what I thought.

But I do not understand how we can change the label on the button, because it does not restart the firewall and we unfortunately cannot do that here.

This would probably be more confusing. Is your intention to have the firewall restart entirely at this point when the user clicks the button?

-Michael

> Now added for 'next' and the 'centered buttons' patch.
> 
> Signed-off-by: Matthias Fischer <matthias.fischer(a)ipfire.org>
> ---
> langs/de/cgi-bin/de.pl | 1 +
> langs/en/cgi-bin/en.pl | 1 +
> 2 files changed, 2 insertions(+)
> 
> diff --git a/langs/de/cgi-bin/de.pl b/langs/de/cgi-bin/de.pl
> index 87181c184..9d403b883 100644
> --- a/langs/de/cgi-bin/de.pl
> +++ b/langs/de/cgi-bin/de.pl
> @@ -1110,6 +1110,7 @@
> 'fw settings dropdown' => 'Alle Netzwerke auf Regelerstellungsseite anzeigen',
> 'fw settings remark' => 'Anmerkungen in Regeltabelle anzeigen',
> 'fw settings ruletable' => 'Leere Regeltabellen anzeigen',
> +'fw settings save and restart' => 'Speichern und Neustart',
> 'fwdfw ACCEPT' => 'Akzeptieren (ACCEPT)',
> 'fwdfw DROP' => 'Verwerfen (DROP)',
> 'fwdfw MODE1' => 'Alle Pakete verwerfen',
> diff --git a/langs/en/cgi-bin/en.pl b/langs/en/cgi-bin/en.pl
> index 625c6899f..476d3304c 100644
> --- a/langs/en/cgi-bin/en.pl
> +++ b/langs/en/cgi-bin/en.pl
> @@ -1136,6 +1136,7 @@
> 'fw settings dropdown' => 'Show all networks on rulecreation site',
> 'fw settings remark' => 'Show remarks in ruletable',
> 'fw settings ruletable' => 'Show empty ruletables',
> +'fw settings save and restart' => 'Save and Restart',
> 'fwdfw ACCEPT' => 'ACCEPT',
> 'fwdfw DROP' => 'DROP',
> 'fwdfw MODE1' => 'Drop all packets',
> -- 
> 2.18.0
>