From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [RFC PATCH 1/8] AQM: Use CAKE as default qdisc where appropriate
 instead of fq_codel
Date: Thu, 02 Dec 2021 12:42:55 +0000
Message-ID: <BC613DB3-0BB6-4D1A-8863-F9D897B80F20@ipfire.org>
In-Reply-To: <20211202123748.2525617-1-michael.tremer@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5480696896111031805=="
List-Id: <development.lists.ipfire.org>

--===============5480696896111031805==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello,

It would be great if people could help me test this.

This should improve network latency massively for users with a slow connectio=
n and it should reduce CPU load for people who have a lot of throughput to ha=
ndle.

I lack a sufficiently slow connection to actually see noticeable benefits ove=
r fq_codel and would like to invite everyone who can to give this all a test =
and let me know if things have changed for them.

Best,
-Michael

> On 2 Dec 2021, at 12:37, Michael Tremer <michael.tremer(a)ipfire.org> wrote:
>=20
> This script configures CAKE as default qdisc where appropriate:
>=20
> * It is not suitable to use any queue management on bridges/GRE/VTI/tun
>  interfaces.
> * On Internet-facing interfaces, CAKE is configured in "internet" mode
>  whereas on any zones except RED, it is configured in "metro" mode
>=20
> Signed-off-by: Michael Tremer <michael.tremer(a)ipfire.org>
> ---
> config/udev/enable_codel | 65 ++++++++++++++++++++++++++++++++--------
> 1 file changed, 52 insertions(+), 13 deletions(-)
>=20
> diff --git a/config/udev/enable_codel b/config/udev/enable_codel
> index 6cafd9b26..3ef9b0f59 100644
> --- a/config/udev/enable_codel
> +++ b/config/udev/enable_codel
> @@ -21,9 +21,9 @@
> #                                                                          #
> ############################################################################
>=20
> -LOG_FACILITY=3D"codel"
> +LOG_FACILITY=3D"aqm"
>=20
> -function log() {
> +log() {
> 	logger -t "${LOG_FACILITY}" $@
> }
>=20
> @@ -32,19 +32,58 @@ if [ -z "${INTERFACE}" ]; then
> 	exit 1
> fi
>=20
> -# Do nothing for the loopback device.
> -[ "${INTERFACE}" =3D "lo" ] && exit 0
> -
> case "${ACTION}" in
> 	add|register)
> -		# Change root qdisc to use fq_codel.
> -		/sbin/tc qdisc add root dev ${INTERFACE} fq_codel
> -		ret=3D$?
> -
> -		if [ ${ret} -eq 0 ]; then
> -			log "Codel AQM has been enabled on '${INTERFACE}'."
> -		else
> -			log "Codel AQM could not be enabled on '${INTERFACE}'. Error code: ${re=
t}"
> +		TYPE=3D"$(</sys/class/net/${INTERFACE}/type)"
> +
> +		# Detect bridges
> +		if [ -d "/sys/class/net/${INTERFACE}/bridge" ]; then
> +			TYPE=3D"bridge"
> +		fi
> +
> +		args=3D()
> +
> +		# Configure some useful defaults depending on the interface
> +		case "${INTERFACE},${TYPE}" in
> +			# Ignore loopback
> +			lo,*)
> +				exit 0
> +				;;
> +
> +			# Ignore tun
> +			tun*)
> +				exit 0
> +				;;
> +
> +			# Ignore GRE/VTI
> +			*,778|*,768)
> +				exit 0
> +				;;
> +
> +			# Ignore bridges
> +			*,bridge)
> +				exit 0
> +				;;
> +
> +			# Handle RED PPPoE (default to VDSL2)
> +			ppp*,512)
> +				args+=3D( "cake" "internet" "pppoe-ptm" "ack-filter" )
> +				;;
> +
> +			# Treat any other interfaces as "Ethernet"
> +			red*,*)
> +				args+=3D( "cake" "internet" "ethernet" )
> +				;;
> +
> +			# All other interfaces are locally connected
> +			*)
> +				args+=3D( "cake" "ethernet" "metro" )
> +				;;
> +		esac
> +
> +		# Change root qdisc to use cake
> +		if ! tc qdisc replace root dev "${INTERFACE}" "${args[@]}"; then
> +			log "Could not configure qdisc on ${INTERFACE} with parameters ${args[@=
]}"
> 			exit ${ret}
> 		fi
> 		;;
> --=20
> 2.30.2
>=20


--===============5480696896111031805==--