public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH 5/5] suricata: Use DNS_SERVERS declaration from external file.
Date: Tue, 05 Nov 2019 10:22:56 +0000	[thread overview]
Message-ID: <BDF46745-4B7C-4259-834A-6DEE9380FC3F@ipfire.org> (raw)
In-Reply-To: <20191105093202.4488-5-stefan.schantl@ipfire.org>

[-- Attachment #1: Type: text/plain, Size: 1378 bytes --]

Hi,

Shouldn’t HOME_NET still be in DNS_SERVERS for users who are running a DNS server behind their firewall?

> On 5 Nov 2019, at 09:32, Stefan Schantl <stefan.schantl(a)ipfire.org> wrote:
> 
> These settings now will be read from
> /var/ipfire/suricata/suricata-dns-servers.yaml, which will be
> generated by the generate_dns_servers_file() function, located in
> ids-functions.pl and called by various scripts.
> 
> Fixes #12166.
> 
> Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
> ---
> config/suricata/suricata.yaml | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/config/suricata/suricata.yaml b/config/suricata/suricata.yaml
> index e921781cf..af9cb75a9 100644
> --- a/config/suricata/suricata.yaml
> +++ b/config/suricata/suricata.yaml
> @@ -11,12 +11,14 @@ vars:
>     # Include HOME_NET declaration from external file.
>     include: /var/ipfire/suricata/suricata-homenet.yaml
> 
> +    # Include DNS_SERVERS declaration from external file.
> +    include: /var/ipfire/suricata/suricata-dns-servers.yaml
> +
>     EXTERNAL_NET: "any"
> 
>     HTTP_SERVERS: "$HOME_NET"
>     SMTP_SERVERS: "$HOME_NET"
>     SQL_SERVERS: "$HOME_NET"
> -    DNS_SERVERS: "$HOME_NET"
>     TELNET_SERVERS: "$HOME_NET"
>     AIM_SERVERS: "$EXTERNAL_NET"
>     DC_SERVERS: "$HOME_NET"
> -- 
> 2.20.1
> 


  reply	other threads:[~2019-11-05 10:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-05  9:31 [PATCH 1/5] ids-functions.pl: Introduce generate_dns_servers_file() Stefan Schantl
2019-11-05  9:31 ` [PATCH 2/5] ids.cgi: Generate and store the DNS server configuration Stefan Schantl
2019-11-05  9:32 ` [PATCH 3/5] convert-snort: Generate DNS servers file Stefan Schantl
2019-11-05  9:32 ` [PATCH 4/5] red.up: Generate Suricata DNS servers file on reconnect Stefan Schantl
2019-11-05  9:32 ` [PATCH 5/5] suricata: Use DNS_SERVERS declaration from external file Stefan Schantl
2019-11-05 10:22   ` Michael Tremer [this message]
2019-11-05 12:45     ` Stefan Schantl
2019-11-05 15:47       ` Michael Tremer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BDF46745-4B7C-4259-834A-6DEE9380FC3F@ipfire.org \
    --to=michael.tremer@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox