Re: [PATCH] util-linux: Do not ship broken symlink "/usr/bin/x86_64"

[Michael Tremer <michael.tremer@ipfire.org>]

[-- Attachment #1: Type: text/plain, Size: 2449 bytes --]

Agreed.

> On 12 Jul 2022, at 12:42, Peter Müller <peter.mueller(a)ipfire.org> wrote:
> 
> Okay, then I'll vote for dropping the broken symlink, as nobody has asked for "setarch" in years.
> 
>> Oh no, we should of course ship setarch or drop x86_64. Either or the other.
>> 
>> I missed that we were talking about a *broken* symlink here.
>> 
>>> On 12 Jul 2022, at 11:44, Peter Müller <peter.mueller(a)ipfire.org> wrote:
>>> 
>>> Hello Michael,
>>> 
>>> thanks for your reply.
>>> 
>>>> Hello,
>>>> 
>>>> Err, yes, but what do we gain from dropping this?
>>> 
>>> Well, shipping a broken symlink did not seem to serve any purpose to me. Or were
>>> you referring to not shipping /usr/bin/setarch?
>>> 
>>> Thanks, and best regards,
>>> Peter Müller
>>> 
>>>> 
>>>> Does it hurt us to be compatible with any general purpose distribution?
>>>> 
>>>> -Michael
>>>> 
>>>>> On 9 Jul 2022, at 14:37, Peter Müller <peter.mueller(a)ipfire.org> wrote:
>>>>> 
>>>>> This file points to /usr/bin/setarch, which we do not ship on any
>>>>> architecture. As it serves no obvious purpose on IPFire installations,
>>>>> we may as well not ship it entirely.
>>>>> 
>>>>> Signed-off-by: Peter Müller <peter.mueller(a)ipfire.org>
>>>>> ---
>>>>> config/rootfiles/common/x86_64/util-linux | 2 +-
>>>>> config/rootfiles/core/170/update.sh       | 1 +
>>>>> 2 files changed, 2 insertions(+), 1 deletion(-)
>>>>> 
>>>>> diff --git a/config/rootfiles/common/x86_64/util-linux b/config/rootfiles/common/x86_64/util-linux
>>>>> index bd862b557..de78f65c2 100644
>>>>> --- a/config/rootfiles/common/x86_64/util-linux
>>>>> +++ b/config/rootfiles/common/x86_64/util-linux
>>>>> @@ -103,7 +103,7 @@ usr/bin/uclampset
>>>>> usr/bin/uuidgen
>>>>> usr/bin/uuidparse
>>>>> #usr/bin/whereis
>>>>> -usr/bin/x86_64
>>>>> +#usr/bin/x86_64
>>>>> #usr/include/blkid
>>>>> #usr/include/blkid/blkid.h
>>>>> #usr/include/libfdisk
>>>>> diff --git a/config/rootfiles/core/170/update.sh b/config/rootfiles/core/170/update.sh
>>>>> index e3f93df57..5d8903189 100644
>>>>> --- a/config/rootfiles/core/170/update.sh
>>>>> +++ b/config/rootfiles/core/170/update.sh
>>>>> @@ -57,6 +57,7 @@ rm -rvf \
>>>>> 	/sbin/ifcfg \
>>>>> 	/sbin/routef \
>>>>> 	/sbin/rtpr \
>>>>> +	/usr/bin/x86_64 \
>>>>> 	/usr/lib/libbfd-2.36.* \
>>>>> 	/usr/lib/libbind9-9.16.2* \
>>>>> 	/usr/lib/libdnet* \
>>>>> -- 
>>>>> 2.35.3
>>>> 
>>