From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Erik K." <ummeegge@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: openvpn broken in 13
Date: Mon, 10 Sep 2012 11:02:11 +0200
Message-ID: <BEEEF143-A80B-43BE-A125-E4B031CF40A2@ipfire.org>
In-Reply-To: <1347264531.17767.173.camel@rice-oxley.tremer.info>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7219749154430482130=="
List-Id: <development.lists.ipfire.org>

--===============7219749154430482130==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi all,
the patch is working for me, after patching the ovpnmain.cgi the package size=
 is per default 1400 MTU and fragment and mssfix doesn=C2=B4t appear. If i ad=
just a value for fragment and activate mssfix, both are displayed with the sa=
me values in the configuration files for the server and also for the client c=
onfiguration file, also the MTU can be adjusted and the values are also print=
ed to both configuration files.=20

But i have had some strange messages after patching the ovpnmain.cgi . The lo=
gs said that the keepalive value aren=C2=B4t set for the server and as i cont=
rolled the server.conf there wasn=C2=B4t the keepalive 10 60 value findable. =
After a manual edit over the WUI, keepalive 10 60 was also printed to server.=
conf.=20

So this patch:
--- ovpnmain.cgi.61	2012-09-01 06:49:41.385539818 +0200
+++ ovpnmain.cgi	2012-09-01 06:41:15.804679610 +0200
@@ -356,14 +356,11 @@
     if ($sovpnsettings{CLIENT2CLIENT} eq 'on') {
 	print CONF "client-to-client\n";
     }
-    if ($sovpnsettings{'DPROTOCOL'} eq 'udp') {
-        if ($sovpnsettings{MSSFIX} eq 'on') {
-	    print CONF "mssfix\n";
-        }
-        if ($sovpnsettings{'FRAGMENT'} eq '' || $sovpnsettings{'FRAGMENT'} e=
q 0) {
-		$sovpnsettings{'FRAGMENT'} =3D '1300';
-        }
-        print CONF "fragment $sovpnsettings{'FRAGMENT'}\n";
+    if ($sovpnsettings{MSSFIX} eq 'on') {
+	print CONF "mssfix\n";
+    }
+    if ($sovpnsettings{FRAGMENT} ne '' && $sovpnsettings{'DPROTOCOL'} ne 'tc=
p') {
+	print CONF "fragment $sovpnsettings{'FRAGMENT'}\n";  =20
     }
     if ($sovpnsettings{KEEPALIVE_1} > 0 && $sovpnsettings{KEEPALIVE_2} > 0) =
{=09
 	print CONF "keepalive $sovpnsettings{'KEEPALIVE_1'} $sovpnsettings{'KEEPALI=
VE_2'}\n";
@@ -532,7 +529,7 @@
     	}
     }
     if ($cgiparams{'MSSFIX'} ne 'on') {
-    	$vpnsettings{'MSSFIX'} =3D 'off';
+    	delete $vpnsettings{'MSSFIX'};
     } else {
     	$vpnsettings{'MSSFIX'} =3D $cgiparams{'MSSFIX'};
     }
@@ -1906,12 +1903,6 @@
     if ($cgiparams{'LOG_VERB'} eq '') {
 	$cgiparams{'LOG_VERB'} =3D  '3';
     }
-    if ($cgiparams{'MSSFIX'} eq '') {
-        $cgiparams{'MSSFIX'} =3D 'on';
-    }
-    if ($cgiparams{'FRAGMENT'} eq '') {
-        $cgiparams{'FRAGMENT'} =3D '1300';
-    }
     $checked{'CLIENT2CLIENT'}{'off'} =3D '';
     $checked{'CLIENT2CLIENT'}{'on'} =3D '';
     $checked{'CLIENT2CLIENT'}{$cgiparams{'CLIENT2CLIENT'}} =3D 'CHECKED';


doesn=C2=B4t contain changes for keepalive so i=C2=B4am pretty unsure where i=
t comes from. Does someone have similar log entries or is it maybe only a ind=
ividual problem?

Erik
 =20
Am 10.09.2012 um 10:08 schrieb Michael Tremer:

> On Fri, 2012-09-07 at 12:26 -0500, R. W. Rodolico wrote:
>> All of my tests so far have shown the patch to be effective. I agree
>> that it was likely a bug that crept in on the new code (would be nice to
>> have some effective beta testing -- oops, I'm the one that should have
>> done that).
>=20
> Indeed :D
>=20
> I am waiting for some more responses about the patch. I think we are
> clear to go, but still need more people to test it.
>=20
> Michael
>=20
> _______________________________________________
> Development mailing list
> Development(a)lists.ipfire.org
> http://lists.ipfire.org/mailman/listinfo/development


--===============7219749154430482130==--