Hello,

I believe that this breaks a lot.

My IPFire 3 VM no longer has any keyboard. I suppose it is that the USB controllers have not been loaded, but I am not sure. I did not have enough time to figure this out, yet.

So this is a NACK.

-Michael

> On 26 Dec 2022, at 20:30, Peter Müller <peter.mueller(a)ipfire.org> wrote:
> 
> There is no harm in doing so, and particularly
> CONFIG_USB_ROLES_INTEL_XHCI is reminiscent of #12750, which has only
> been observed on a board manufactured by TX Team that contains Intel
> XHCI USB hardware. Let's give enabling this option a try.
> 
> Signed-off-by: Peter Müller <peter.mueller(a)ipfire.org>
> ---
> config/kernel/kernel.config.x86_64-ipfire | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/config/kernel/kernel.config.x86_64-ipfire b/config/kernel/kernel.config.x86_64-ipfire
> index 5a8a9e14b..f1d6c2ede 100644
> --- a/config/kernel/kernel.config.x86_64-ipfire
> +++ b/config/kernel/kernel.config.x86_64-ipfire
> @@ -5624,7 +5624,7 @@ CONFIG_USB_MON=m
> #
> # USB Host Controller Drivers
> #
> -# CONFIG_USB_C67X00_HCD is not set
> +CONFIG_USB_C67X00_HCD=m
> CONFIG_USB_XHCI_HCD=y
> # CONFIG_USB_XHCI_DBGCAP is not set
> CONFIG_USB_XHCI_PCI=y
> @@ -5634,11 +5634,11 @@ CONFIG_USB_EHCI_HCD=y
> CONFIG_USB_EHCI_ROOT_HUB_TT=y
> CONFIG_USB_EHCI_TT_NEWSCHED=y
> CONFIG_USB_EHCI_PCI=y
> -# CONFIG_USB_EHCI_FSL is not set
> +CONFIG_USB_EHCI_FSL=y
> CONFIG_USB_EHCI_HCD_PLATFORM=y
> -# CONFIG_USB_OXU210HP_HCD is not set
> -# CONFIG_USB_ISP116X_HCD is not set
> -# CONFIG_USB_FOTG210_HCD is not set
> +CONFIG_USB_OXU210HP_HCD=m
> +CONFIG_USB_ISP116X_HCD=m
> +CONFIG_USB_FOTG210_HCD=m
> CONFIG_USB_OHCI_HCD=y
> CONFIG_USB_OHCI_HCD_PCI=m
> CONFIG_USB_OHCI_HCD_PLATFORM=y
> @@ -5763,7 +5763,7 @@ CONFIG_USB_SERIAL_SPCP8X5=m
> # CONFIG_USB_SERIAL_SAFE is not set
> CONFIG_USB_SERIAL_SIERRAWIRELESS=m
> # CONFIG_USB_SERIAL_SYMBOL is not set
> -# CONFIG_USB_SERIAL_TI is not set
> +CONFIG_USB_SERIAL_TI=m
> # CONFIG_USB_SERIAL_CYBERJACK is not set
> CONFIG_USB_SERIAL_WWAN=m
> CONFIG_USB_SERIAL_OPTION=m
> @@ -5803,9 +5803,9 @@ CONFIG_USB_YUREX=m
> CONFIG_USB_EZUSB_FX2=m
> CONFIG_USB_HUB_USB251XB=m
> CONFIG_USB_HSIC_USB3503=m
> -# CONFIG_USB_HSIC_USB4604 is not set
> +CONFIG_USB_HSIC_USB4604=m
> # CONFIG_USB_LINK_LAYER_TEST is not set
> -# CONFIG_USB_CHAOSKEY is not set
> +CONFIG_USB_CHAOSKEY=m
> CONFIG_USB_ATM=m
> CONFIG_USB_SPEEDTOUCH=m
> CONFIG_USB_CXACRU=m
> @@ -5849,7 +5849,7 @@ CONFIG_UCSI_ACPI=m
> # end of USB Type-C Alternate Mode drivers
> 
> CONFIG_USB_ROLE_SWITCH=m
> -# CONFIG_USB_ROLES_INTEL_XHCI is not set
> +CONFIG_USB_ROLES_INTEL_XHCI=m
> CONFIG_MMC=m
> CONFIG_MMC_BLOCK=m
> CONFIG_MMC_BLOCK_MINORS=8
> -- 
> 2.35.3