From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [Patch RFC 06/15] network scripts: remove check for AUTOCONNECT
Date: Wed, 24 May 2023 10:00:14 +0100
Message-ID: <C1A4FA7A-857C-4E2F-BBEF-E385CBB20DE7@ipfire.org>
In-Reply-To: <20230523172314.7826-7-jonatan.schlag@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7410566489067487911=="
List-Id: <development.lists.ipfire.org>

--===============7410566489067487911==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

True, we no longer support dial-on-demand.

> On 23 May 2023, at 18:23, Jonatan Schlag <jonatan.schlag(a)ipfire.org> wrot=
e:
>=20
> This setting is also old (2007) and cannot be set via the webinterface
> anymore. So why checking for something, which can only be true.
>=20
> Signed-off-by: Jonatan Schlag <jonatan.schlag(a)ipfire.org>
> ---
> src/initscripts/system/network | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/src/initscripts/system/network b/src/initscripts/system/network
> index 146b3fda8..6a47456f3 100644
> --- a/src/initscripts/system/network
> +++ b/src/initscripts/system/network
> @@ -63,7 +63,7 @@ case "${DO}" in
> if [ "$red" =3D=3D "1" ]; then
> # Remove possible leftover files
> rm -f /var/ipfire/red/{active,device,dial-on-demand,dns1,dns2,local-ipaddre=
ss,remote-ipaddress,resolv.conf}
> - [ "$AUTOCONNECT" =3D=3D "off" ] || /etc/rc.d/init.d/networking/red start
> + /etc/rc.d/init.d/networking/red start
> fi
>=20
> /etc/rc.d/init.d/static-routes start
> --=20
> 2.30.2
>=20


--===============7410566489067487911==--