Re: [PATCH 0/3] Help for GUI

[Jon Murphy <jcmurphy26@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2537 bytes --]

Oops…  maybe my bad?


> 
> ------------------------------
> 
> Message: 3
> Date: Sat, 16 May 2020 10:35:00 +0100
> From: Michael Tremer <michael.tremer(a)ipfire.org>
> To: Tim FitzGeorge <ipfr(a)tfitzgeorge.me.uk>
> Cc: development(a)lists.ipfire.org
> Subject: Re: [PATCH 0/3] Help for GUI
> Message-ID: <6390F8AE-998D-489E-A983-1A875E2761F2(a)ipfire.org>
> Content-Type: text/plain;	charset=utf-8
> 
> Hi Tim,
> 
> Thank you very much for submitting these patches.
> 
> I am afraid that I must say that I oppose these changes.
> 
> This has recently been discussed on the community portal and although I still have not made my mind up entirely, I think this not helpful to anyone:
> 
> * We do not have documentation for everything for a start
> * There is never this ?just read one sentence and you suddenly will be an expert? thing this kind of promotes
> 
> Should we not rather link the wiki somewhere in the footer and encourage people to start reading the whole thing from the start before they do something?
> 
> What is your rationale to implementing this?
> 
> Best,
> -Michael
> 
>> On 15 May 2020, at 22:39, Tim FitzGeorge <ipfr(a)tfitzgeorge.me.uk> wrote:
>> 
>> Add per-page help link to GUI.
>> The link is extracted from the menu file and added to the menu.
>> Currently only implemented for 'ipfire' and 'ipfire-rounded' themes.
>> 
>> Tim FitzGeorge (3):
>> Help for GUI - ipfire theme code
>> Help for GUI - Help links
>> Help for GUI - help link style
>> 
>> config/menu/10-system.menu                    | 11 +++++++
>> config/menu/20-status.menu                    | 13 ++++++++
>> config/menu/30-network.menu                   | 20 +++++++++--
>> config/menu/40-services.menu                  |  6 ++++
>> config/menu/50-firewall.menu                  |  8 ++++-
>> config/menu/60-ipfire.menu                    |  1 +
>> config/menu/70-log.menu                       | 33 ++++++++++++-------
>> config/menu/EX-apcupsd.menu                   |  1 +
>> config/menu/EX-guardian.menu                  |  1 +
>> config/menu/EX-mpfire.menu                    |  1 +
>> config/menu/EX-samba.menu                     |  1 +
>> config/menu/EX-tor.menu                       |  1 +
>> config/menu/EX-wlanap.menu                    |  1 +
>> html/html/themes/ipfire/include/css/style.css |  8 +++++
>> html/html/themes/ipfire/include/functions.pl  | 19 +++++++++--
>> 15 files changed, 107 insertions(+), 18 deletions(-)
>> 
>> --
>> 2.26.1
>> 
> 
>