public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] qos.cgi: Removed last two P2P lines
Date: Mon, 04 Apr 2022 09:34:00 +0100	[thread overview]
Message-ID: <C3EBEEE1-4663-478A-9744-55DD92F602E5@ipfire.org> (raw)
In-Reply-To: <20220403160404.5577-1-matthias.fischer@ipfire.org>

[-- Attachment #1: Type: text/plain, Size: 1383 bytes --]

Hello Matthias,

Although this mentions the phrase “P2P”, this has nothing to do with the filter.

This creates a class which uses the l7 filter to match any P2P traffic and throttle it.

Please drop this patch as it would create an inconsistent QoS configuration since the rules in that class are not deleted.

-Michael

> On 3 Apr 2022, at 17:04, Matthias Fischer <matthias.fischer(a)ipfire.org> wrote:
> 
> P2P "has left da house"...
> 
> Signed-off-by: Matthias Fischer <matthias.fischer(a)ipfire.org>
> ---
> html/cgi-bin/qos.cgi | 2 --
> 1 file changed, 2 deletions(-)
> 
> diff --git a/html/cgi-bin/qos.cgi b/html/cgi-bin/qos.cgi
> index f3bbd1bf4..6d1c61638 100644
> --- a/html/cgi-bin/qos.cgi
> +++ b/html/cgi-bin/qos.cgi
> @@ -474,13 +474,11 @@ imq0;200;1;$DOWN[20];$DOWN[1];;;8;VoIP;
> imq0;203;4;$DOWN[20];$DOWN[1];;;0;VPN;
> imq0;204;5;$DOWN[20];$DOWN[1];;;8;Webtraffic;
> imq0;210;6;1;$DOWN[1];;;0;Default;
> -imq0;220;7;1;$DOWN[1];;;1;P2P;
> $qossettings{'RED_DEV'};101;1;$UP[10];$UP[1];;;8;ACKs;
> $qossettings{'RED_DEV'};102;2;$UP[10];$UP[1];;;8;VoIP;
> $qossettings{'RED_DEV'};103;4;$UP[10];$UP[1];;;2;VPN;
> $qossettings{'RED_DEV'};104;5;$UP[10];$UP[1];;;8;Webtraffic;
> $qossettings{'RED_DEV'};110;6;1;$UP[1];;;0;Default;
> -$qossettings{'RED_DEV'};120;7;1;$UP[1];;;1;P2P;
> END
> ;
> 		close FILE;
> -- 
> 2.25.1
> 


  parent reply	other threads:[~2022-04-04  8:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-03 16:04 Matthias Fischer
2022-04-04  5:28 ` Peter Müller
2022-04-04  8:34 ` Michael Tremer [this message]
2022-04-04 16:15   ` Matthias Fischer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C3EBEEE1-4663-478A-9744-55DD92F602E5@ipfire.org \
    --to=michael.tremer@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox