From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Tremer To: development@lists.ipfire.org Subject: Re: [PATCH] qos.cgi: Removed last two P2P lines Date: Mon, 04 Apr 2022 09:34:00 +0100 Message-ID: In-Reply-To: <20220403160404.5577-1-matthias.fischer@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6750858288868219458==" List-Id: --===============6750858288868219458== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hello Matthias, Although this mentions the phrase =E2=80=9CP2P=E2=80=9D, this has nothing to = do with the filter. This creates a class which uses the l7 filter to match any P2P traffic and th= rottle it. Please drop this patch as it would create an inconsistent QoS configuration s= ince the rules in that class are not deleted. -Michael > On 3 Apr 2022, at 17:04, Matthias Fischer w= rote: >=20 > P2P "has left da house"... >=20 > Signed-off-by: Matthias Fischer > --- > html/cgi-bin/qos.cgi | 2 -- > 1 file changed, 2 deletions(-) >=20 > diff --git a/html/cgi-bin/qos.cgi b/html/cgi-bin/qos.cgi > index f3bbd1bf4..6d1c61638 100644 > --- a/html/cgi-bin/qos.cgi > +++ b/html/cgi-bin/qos.cgi > @@ -474,13 +474,11 @@ imq0;200;1;$DOWN[20];$DOWN[1];;;8;VoIP; > imq0;203;4;$DOWN[20];$DOWN[1];;;0;VPN; > imq0;204;5;$DOWN[20];$DOWN[1];;;8;Webtraffic; > imq0;210;6;1;$DOWN[1];;;0;Default; > -imq0;220;7;1;$DOWN[1];;;1;P2P; > $qossettings{'RED_DEV'};101;1;$UP[10];$UP[1];;;8;ACKs; > $qossettings{'RED_DEV'};102;2;$UP[10];$UP[1];;;8;VoIP; > $qossettings{'RED_DEV'};103;4;$UP[10];$UP[1];;;2;VPN; > $qossettings{'RED_DEV'};104;5;$UP[10];$UP[1];;;8;Webtraffic; > $qossettings{'RED_DEV'};110;6;1;$UP[1];;;0;Default; > -$qossettings{'RED_DEV'};120;7;1;$UP[1];;;1;P2P; > END > ; > close FILE; > --=20 > 2.25.1 >=20 --===============6750858288868219458==--